chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java - Issue 199733002: Cleanup AppMenu code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java

Issue 199733002: Cleanup AppMenu code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move lint suppression to AppMenuDragHelper Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java ('k') | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java

index 3d01024c823e7b23953689009ac28599ed2d007a..9fcad5406788ae5fc9b0ffcac48ba19e4c3053f9 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectFileDialogTest.java

@@ -12,7 +12,7 @@ import android.test.suitebuilder.annotation.MediumTest;

import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.UrlUtils;

import org.chromium.chrome.shell.ChromeShellActivity;

-import org.chromium.chrome.shell.ChromeShellActivity.WindowAndroidFactoryForTest;

+import org.chromium.chrome.shell.ChromeShellActivity.ActivityWindowAndroidFactory;

import org.chromium.chrome.shell.ChromeShellTestBase;

import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.test.util.Criteria;

@@ -69,7 +69,7 @@ public class SelectFileDialogTest extends ChromeShellTestBase {

public void setUp() throws Exception {

super.setUp();

- ChromeShellActivity.setActivityWindowAndroidFactory(new WindowAndroidFactoryForTest() {

+ ChromeShellActivity.setActivityWindowAndroidFactory(new ActivityWindowAndroidFactory() {

@Override

public ActivityWindowAndroid getActivityWindowAndroid(Activity activity) {

mActivityWindowAndroidForTest = new ActivityWindowAndroidForTest(activity);