Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 19972003: [Telemetry] Default to most recent local build if --browser is omitted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index 8e20cec1ca85975a9e8be541e80b1ecb70fb2d90..ce849823eff87ba41d49962ea6117fcb6ebf5be6 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -154,10 +154,16 @@ def Run(test, page_set, expectations, options):
# Create a possible_browser with the given options.
test.CustomizeBrowserOptions(options)
- possible_browser = browser_finder.FindBrowser(options)
+ try:
+ possible_browser = browser_finder.FindBrowser(options)
+ except browser_finder.BrowserTypeRequiredException, e:
+ sys.stderr.write(str(e) + '\n')
+ sys.exit(1)
if not possible_browser:
- raise Exception('No browser found.\n'
- 'Use --browser=list to figure out which are available.')
+ sys.stderr.write(
+ 'No browser found. Available browsers:\n' +
+ '\n'.join(browser_finder.GetAllAvailableBrowserTypes(options)) + '\n')
+ sys.exit(1)
# Reorder page set based on options.
pages = _ShuffleAndFilterPageSet(page_set, options)
« no previous file with comments | « tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698