tools/telemetry/telemetry/core/browser_options.py - Issue 19972003: [Telemetry] Default to most recent local build if --browser is omitted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/browser_options.py

Issue 19972003: [Telemetry] Default to most recent local build if --browser is omitted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/browser_finder.py ('k') | tools/telemetry/telemetry/core/chrome/android_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/browser_options.py

diff --git a/tools/telemetry/telemetry/core/browser_options.py b/tools/telemetry/telemetry/core/browser_options.py

index 5c8f6e5d8d58ff6428820a86248ff6c73e0da5b9..6e928ce547f39bd24112acefb59a874a52a6c3cb 100644

--- a/tools/telemetry/telemetry/core/browser_options.py

+++ b/tools/telemetry/telemetry/core/browser_options.py

@@ -177,10 +177,6 @@ class BrowserOptions(optparse.Values):

if self.browser_executable and not self.browser_type:

self.browser_type = 'exact'

- if not self.browser_executable and not self.browser_type:

- sys.stderr.write('Must provide --browser=<type>. ' +

- 'Use --browser=list for valid options.\n')

- sys.exit(1)

if self.browser_type == 'list':

try:

types = browser_finder.GetAllAvailableBrowserTypes(self)