Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 19972002: ARM: Ensure space for lazy deoptimization before calling IC. (Closed)

Created:
7 years, 5 months ago by ulan
Modified:
7 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

ARM: Ensure space for lazy deoptimization before calling IC. If IC triggers deoptimization, then subsequent patching might get invalid target address that was overwritten. R=verwaest@chromium.org BUG=247688 TEST=mjsunit/regress/regress-247688.js Committed: https://code.google.com/p/v8/source/detail?r=15808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -10 lines) Patch
M src/arm/lithium-codegen-arm.cc View 5 chunks +5 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-247688.js View 1 chunk +47 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
7 years, 5 months ago (2013-07-22 17:06:57 UTC) #1
Toon Verwaest
lgtm
7 years, 5 months ago (2013-07-22 17:10:29 UTC) #2
ulan
7 years, 5 months ago (2013-07-22 17:21:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15808 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698