build/android/pylib/android_commands.py - Issue 19968004: Reimplement device status check dashboard option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/android_commands.py

Issue 19968004: Reimplement device status check dashboard option. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove exlicit call to default emulator=True. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/android_commands.py

diff --git a/build/android/pylib/android_commands.py b/build/android/pylib/android_commands.py

index 4cba47a296adca741d45037c5e164ca4bfe59e97..1cb6718a959994bf9a25272fd4dbb30ac2f01e13 100644

--- a/build/android/pylib/android_commands.py

+++ b/build/android/pylib/android_commands.py

@@ -1015,7 +1015,7 @@ class AndroidCommands(object):

def GetWifiIP(self):

"""Returns the wifi IP on the device."""

wifi_ip = self.RunShellCommand('getprop dhcp.wlan0.ipaddress')[0]

- assert wifi_ip

+ # Do not assert here. Devices (e.g. emulators) may not have a WifiIP.

return wifi_ip

def GetSubscriberInfo(self):

« no previous file with comments | « build/android/buildbot/bb_device_status_check.py ('k') | no next file » | no next file with comments »