Make painting a single frame a permanent API on VideoRendererSink.

Make painting a single frame a permanent API on VideoRendererSink.

Having to call VRS::Start(), wait for VRS::RC::Render(), and then
queuing a VRS::Stop() across multiple threads just to paint a
single frame is not desirable... so remove a bunch of TODOs and
rename PaintFrameUsingOldRenderingPath() to PaintSingleFrame().

This allows a lot of simplification in VideoRendererImpl and avoids
Chromecast from having to pick up this complexity. It also will
likely resolve nullptr crashes due having two sink startup points.

BUG=611714
TEST=existing unittests pass.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/e9c89e91623714fe04fd20c5caaee03dcae021e5
Cr-Commit-Position: refs/heads/master@{#395138}

[DaleCurtis, 2016-05-19 21:54:38]

Description was changed from

==========
Make painting a single frame a permanent API on VideoRendererSink.

Having to call VRS::Start(), wait for VRS::RC::Render(), and then
queuing a VRS::Stop() across multiple threads just to paint a
single frame is not desirable... so remove a bunch of TODOs and
rename PaintFrameUsingOldRenderingPath() to PaintSingleFrame().

This allows a lot of simplification in VideoRendererImpl and avoids
Chromecast from having to pick up this complexity. It also will
likely resolve nullptr crashes do having two sink startup points.

BUG=611714
TEST=
==========

to

==========
Make painting a single frame a permanent API on VideoRendererSink.

Having to call VRS::Start(), wait for VRS::RC::Render(), and then
queuing a VRS::Stop() across multiple threads just to paint a
single frame is not desirable... so remove a bunch of TODOs and
rename PaintFrameUsingOldRenderingPath() to PaintSingleFrame().

This allows a lot of simplification in VideoRendererImpl and avoids
Chromecast from having to pick up this complexity. It also will
likely resolve nullptr crashes do having two sink startup points.

BUG=611714
TEST=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[DaleCurtis, 2016-05-19 22:32:25]

dalecurtis@chromium.org changed reviewers:
+ alokp@chromium.org, danakj@chromium.org, xhwang@chromium.org

[DaleCurtis, 2016-05-19 22:32:26]

alokp: chromecast/, optional media/ review.
xhwang: media/ review.
danakj: cc/ comment cleanup.

[DaleCurtis, 2016-05-19 22:32:35]

Patchset #1 (id:1) has been deleted

[DaleCurtis, 2016-05-19 22:32:49]

Description was changed from

==========
Make painting a single frame a permanent API on VideoRendererSink.

Having to call VRS::Start(), wait for VRS::RC::Render(), and then
queuing a VRS::Stop() across multiple threads just to paint a
single frame is not desirable... so remove a bunch of TODOs and
rename PaintFrameUsingOldRenderingPath() to PaintSingleFrame().

This allows a lot of simplification in VideoRendererImpl and avoids
Chromecast from having to pick up this complexity. It also will
likely resolve nullptr crashes do having two sink startup points.

BUG=611714
TEST=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Make painting a single frame a permanent API on VideoRendererSink.

Having to call VRS::Start(), wait for VRS::RC::Render(), and then
queuing a VRS::Stop() across multiple threads just to paint a
single frame is not desirable... so remove a bunch of TODOs and
rename PaintFrameUsingOldRenderingPath() to PaintSingleFrame().

This allows a lot of simplification in VideoRendererImpl and avoids
Chromecast from having to pick up this complexity. It also will
likely resolve nullptr crashes do having two sink startup points.

BUG=611714
TEST=existing unittests pass.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-05-19 22:35:33]

LGTM

[DaleCurtis, 2016-05-19 22:39:00]

Description was changed from

==========
Make painting a single frame a permanent API on VideoRendererSink.

Having to call VRS::Start(), wait for VRS::RC::Render(), and then
queuing a VRS::Stop() across multiple threads just to paint a
single frame is not desirable... so remove a bunch of TODOs and
rename PaintFrameUsingOldRenderingPath() to PaintSingleFrame().

This allows a lot of simplification in VideoRendererImpl and avoids
Chromecast from having to pick up this complexity. It also will
likely resolve nullptr crashes do having two sink startup points.

BUG=611714
TEST=existing unittests pass.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Make painting a single frame a permanent API on VideoRendererSink.

Having to call VRS::Start(), wait for VRS::RC::Render(), and then
queuing a VRS::Stop() across multiple threads just to paint a
single frame is not desirable... so remove a bunch of TODOs and
rename PaintFrameUsingOldRenderingPath() to PaintSingleFrame().

This allows a lot of simplification in VideoRendererImpl and avoids
Chromecast from having to pick up this complexity. It also will
likely resolve nullptr crashes due having two sink startup points.

BUG=611714
TEST=existing unittests pass.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[alokp, 2016-05-19 22:39:57]

lgtm

[xhwang, 2016-05-19 22:47:28]

Nice cleanup. LGTM

https://chromiumcodereview.appspot.com/1996763002/diff/20001/media/base/video...
File media/base/video_renderer_sink.h (right):

https://chromiumcodereview.appspot.com/1996763002/diff/20001/media/base/video...
media/base/video_renderer_sink.h:59: // Start() -> Render() -> Stop().
nit: Can we call both PSF and Start/Render/Stop?

[DaleCurtis, 2016-05-20 18:18:40]

https://chromiumcodereview.appspot.com/1996763002/diff/20001/media/base/video...
File media/base/video_renderer_sink.h (right):

https://chromiumcodereview.appspot.com/1996763002/diff/20001/media/base/video...
media/base/video_renderer_sink.h:59: // Start() -> Render() -> Stop().
On 2016/05/19 at 22:47:28, xhwang wrote:
> nit: Can we call both PSF and Start/Render/Stop?

Yes, I've updated the docs.

[DaleCurtis, 2016-05-20 18:18:46]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-05-20 18:18:52]

The CQ bit was unchecked by dalecurtis@chromium.org

[DaleCurtis, 2016-05-20 18:19:05]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-05-20 18:19:05]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
xhwang@chromium.org, alokp@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1996763002/#ps40001
(title: "Comments.")

[commit-bot: I haz the power, 2016-05-20 18:19:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1996763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1996763002/40001

[commit-bot: I haz the power, 2016-05-20 19:38:12]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-20 19:40:51]

Description was changed from

==========
Make painting a single frame a permanent API on VideoRendererSink.

Having to call VRS::Start(), wait for VRS::RC::Render(), and then
queuing a VRS::Stop() across multiple threads just to paint a
single frame is not desirable... so remove a bunch of TODOs and
rename PaintFrameUsingOldRenderingPath() to PaintSingleFrame().

This allows a lot of simplification in VideoRendererImpl and avoids
Chromecast from having to pick up this complexity. It also will
likely resolve nullptr crashes due having two sink startup points.

BUG=611714
TEST=existing unittests pass.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Make painting a single frame a permanent API on VideoRendererSink.

Having to call VRS::Start(), wait for VRS::RC::Render(), and then
queuing a VRS::Stop() across multiple threads just to paint a
single frame is not desirable... so remove a bunch of TODOs and
rename PaintFrameUsingOldRenderingPath() to PaintSingleFrame().

This allows a lot of simplification in VideoRendererImpl and avoids
Chromecast from having to pick up this complexity. It also will
likely resolve nullptr crashes due having two sink startup points.

BUG=611714
TEST=existing unittests pass.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/e9c89e91623714fe04fd20c5caaee03dcae021e5
Cr-Commit-Position: refs/heads/master@{#395138}
==========

[commit-bot: I haz the power, 2016-05-20 19:40:52]

Patchset 2 (id:??) landed as
https://crrev.com/e9c89e91623714fe04fd20c5caaee03dcae021e5
Cr-Commit-Position: refs/heads/master@{#395138}