Add color support to git cl and fetch issue properties in parallel.

Add color support to git cl and fetch issue properties in parallel.

Add cache for issue properties.

Add --fast option in case the HTTP requests become an issue.

Everyone loves colors:
- White means no issue is associated with the branch.
- Red means no email was sent to request a review. Also red if the issue doesn't
  exist anymore.
- Blue means the issue was not LGTM'ed yet.
- Green means the issue was LGTM'ed and is likely ready to commit or be CQ'ed.

R=iannucci@chromium.org
BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=213265

[M-A Ruel, 2013-07-22 18:28:27]

Dependent on https://codereview.chromium.org/19976002

Timing is a bit random, for a repository with 12 branches with issues, it varies
from 1.5s to 6.5s but 1.5~2s is the vast majority of the times.

[iannucci, 2013-07-23 02:07:28]

lgtm % comment

https://chromiumcodereview.appspot.com/19967004/diff/1/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/19967004/diff/1/git_cl.py#newcode681
git_cl.py:681: def GetMostRecentPatchset(self, issue):
issue is unused?

[M-A Ruel, 2013-07-23 14:32:42]

https://chromiumcodereview.appspot.com/19967004/diff/1/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/19967004/diff/1/git_cl.py#newcode681
git_cl.py:681: def GetMostRecentPatchset(self, issue):
On 2013/07/23 02:07:28, iannucci wrote:
> issue is unused?

Oops. Did a bit of surgery to fix the thing.

[iannucci, 2013-07-23 18:34:15]

https://chromiumcodereview.appspot.com/19967004/diff/8001/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/19967004/diff/8001/git_cl.py#newcode689
git_cl.py:689: if issue:
probably should do issue is None... technically 0 is a valid issue, I suppose :p

https://chromiumcodereview.appspot.com/19967004/diff/8001/git_cl.py#newcode698
git_cl.py:698: self._props = self.RpcServer().get_issue_properties(issue, True)
Hm, this function is a quite weird... Can't we just change the callsites to make
a new Changelist and then call GetIssueProperties on it?

[M-A Ruel, 2013-07-23 18:49:43]

https://chromiumcodereview.appspot.com/19967004/diff/8001/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/19967004/diff/8001/git_cl.py#newcode689
git_cl.py:689: if issue:
On 2013/07/23 18:34:16, iannucci wrote:
> probably should do issue is None... technically 0 is a valid issue, I suppose
:p

Deleted this code.

https://chromiumcodereview.appspot.com/19967004/diff/8001/git_cl.py#newcode698
git_cl.py:698: self._props = self.RpcServer().get_issue_properties(issue, True)
On 2013/07/23 18:34:16, iannucci wrote:
> Hm, this function is a quite weird... Can't we just change the callsites to
make
> a new Changelist and then call GetIssueProperties on it?

Fixed.

[iannucci, 2013-07-23 19:08:27]

https://chromiumcodereview.appspot.com/19967004/diff/17001/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/19967004/diff/17001/git_cl.py#newcode1804
git_cl.py:1804: issue, False)['patchsets'][-1]
Wouldn't it be pretty easy to just let Changelist take an issue? I think all of
the machinery should work if you set issue explicitly in __init__... so then
this would be:

patchset = Changelist(issue=int(issue_arg)).GetMostRecentPatchset()

??

[M-A Ruel, 2013-07-23 19:32:39]

https://chromiumcodereview.appspot.com/19967004/diff/17001/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/19967004/diff/17001/git_cl.py#newcode1804
git_cl.py:1804: issue, False)['patchsets'][-1]
On 2013/07/23 19:08:27, iannucci wrote:
> Wouldn't it be pretty easy to just let Changelist take an issue? I think all
of
> the machinery should work if you set issue explicitly in __init__... so then
> this would be:
> 
> patchset = Changelist(issue=int(issue_arg)).GetMostRecentPatchset()
> 
> ??

Done.

[iannucci, 2013-07-23 21:19:24]

lgtm

https://chromiumcodereview.appspot.com/19967004/diff/22001/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/19967004/diff/22001/git_cl.py#newcode1738
git_cl.py:1738: cl.SetIssue(None)
if you git cl issue 0, will that still do the right thing?

[M-A Ruel, 2013-07-23 23:22:28]

https://chromiumcodereview.appspot.com/19967004/diff/22001/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/19967004/diff/22001/git_cl.py#newcode1738
git_cl.py:1738: cl.SetIssue(None)
On 2013/07/23 21:19:25, iannucci wrote:
> if you git cl issue 0, will that still do the right thing?

Yes, tested.

[commit-bot: I haz the power, 2013-07-23 23:22:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/19967004/22001

[commit-bot: I haz the power, 2013-07-23 23:25:10]

Change committed as 213265