Issue 19954005: Eliminate map checks of constant values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19954005: Eliminate map checks of constant values. (Closed)

Created:
7 years, 5 months ago by Toon Verwaest

Modified:
7 years, 5 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Eliminate map checks of constant values. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15819

Patch Set 3 : Added test, fixed bug #

Patch Set 4 : Naming #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -65 lines)			Patch
M	src/arm/lithium-arm.cc	View	1	2 chunks	+10 lines, -3 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	3 chunks	+7 lines, -6 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/flag-definitions.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View		7 chunks	+9 lines, -7 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		5 chunks	+19 lines, -7 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 2 3	2 chunks	+17 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/objects.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects-inl.h	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
A +	test/mjsunit/omit-constant-mapcheck.js	View	1 2	1 chunk	+20 lines, -26 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM https://chromiumcodereview.appspot.com/19954005/diff/2001/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/19954005/diff/2001/src/objects.h#newcode5629 src/objects.h:5629: inline bool CanOmitCheckMaps(); I would prefer "CanOmitMapChecks".

7 years, 5 months ago (2013-07-23 09:15:46 UTC) #2

Toon Verwaest

7 years, 5 months ago (2013-07-23 09:18:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r15819 (presubmit successful).