Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19945010: Flush the message loop in StorageMonitorLinux tests. (Closed)

Created:
7 years, 5 months ago by earthdok
Modified:
7 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Lei Zhang, tommycli, Greg Billock, vandebo (ex-Chrome)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Flush the message loop in StorageMonitorLinux tests. Fixes some of the memory leaks in those tests. BUG=222687 R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/storage_monitor/storage_monitor_linux_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
earthdok
ptal
7 years, 5 months ago (2013-07-23 18:55:26 UTC) #1
Lei Zhang
lgtm
7 years, 5 months ago (2013-07-23 19:07:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/19945010/1
7 years, 5 months ago (2013-07-23 19:16:25 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 01:17:25 UTC) #4
Message was sent while issue was closed. 
Change committed as 213309

Powered by Google App Engine
This is Rietveld 408576698