Modal window in user session not blocks user adding screen.

Modal window in user session not blocks user adding screen.

Added IsUserSessionBlocked method indicating whether user session blocked by
some overlying UI (it can be lock/login/user adding UI).
Replaced IsScreenLocked() [|| IsActiveUserSessionStarted()] with
IsUserSessionBlocked() in several places in order to keep focus and user input
in locked container.

BUG=none
TEST=ash_unittests
R=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213524

[sky, 2013-07-22 21:19:06]

https://codereview.chromium.org/19945004/diff/1/ash/session_state_delegate.h
File ash/session_state_delegate.h (right):

https://codereview.chromium.org/19945004/diff/1/ash/session_state_delegate.h#...
ash/session_state_delegate.h:62: virtual bool IsUserSessionBlocked() const = 0;
Blocked is misleading here. In particular it makes it sound like a modal dialog
is showing, which isn't quite what you mean. Is there some other name you could
use? Maybe IsScreenLocked should return an enum?

[dzhioev (left Google), 2013-07-23 14:06:01]

https://codereview.chromium.org/19945004/diff/1/ash/session_state_delegate.h
File ash/session_state_delegate.h (right):

https://codereview.chromium.org/19945004/diff/1/ash/session_state_delegate.h#...
ash/session_state_delegate.h:62: virtual bool IsUserSessionBlocked() const = 0;
On 2013/07/22 21:19:06, sky wrote:
> Blocked is misleading here. In particular it makes it sound like a modal
dialog
> is showing, which isn't quite what you mean. Is there some other name you
could
> use? Maybe IsScreenLocked should return an enum?

'Locked' is already widely used for lock screen, e.g. we have Lock/UnlockScreen
methods. If IsScreenLocked returned enum LockScreen would receive enum as param,
but it makes no sense to call LockScreen(LOGIN_SCREEN). So I think we need some
different name. Maybe 'Hidden'?

[sky, 2013-07-23 14:34:37]

LGTM

https://codereview.chromium.org/19945004/diff/1/ash/session_state_delegate.h
File ash/session_state_delegate.h (right):

https://codereview.chromium.org/19945004/diff/1/ash/session_state_delegate.h#...
ash/session_state_delegate.h:62: virtual bool IsUserSessionBlocked() const = 0;
On 2013/07/23 14:06:01, dzhioev wrote:
> On 2013/07/22 21:19:06, sky wrote:
> > Blocked is misleading here. In particular it makes it sound like a modal
> dialog
> > is showing, which isn't quite what you mean. Is there some other name you
> could
> > use? Maybe IsScreenLocked should return an enum?
> 
> 'Locked' is already widely used for lock screen, e.g. we have
Lock/UnlockScreen
> methods. If IsScreenLocked returned enum LockScreen would receive enum as
param,
> but it makes no sense to call LockScreen(LOGIN_SCREEN). So I think we need
some
> different name. Maybe 'Hidden'?

I think I like IsUserSessionBlocked better. So, stick with what you have here.

[commit-bot: I haz the power, 2013-07-23 14:38:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dzhioev@chromium.org/19945004/1

[commit-bot: I haz the power, 2013-07-23 15:35:43]

Retried try job too often on linux_chromeos for step(s) ash_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-07-23 16:44:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dzhioev@chromium.org/19945004/24001

[commit-bot: I haz the power, 2013-07-23 18:05:17]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-07-24 16:57:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dzhioev@chromium.org/19945004/43001

[commit-bot: I haz the power, 2013-07-24 21:49:36]

Change committed as 213524