MacViews: Make buttons not request focus on mouse press.

MacViews: Make buttons not request focus on mouse press.

On Cocoa, buttons never request focus on a mouse press. This CL changes
CustomButton::set_request_on_press to ensure buttons in MacViews also follow
this behavior.

BUG=611259
Committed: https://crrev.com/3963480dc371af9a4569ac91d982720b66783928
Cr-Commit-Position: refs/heads/master@{#394971}

[karandeepb, 2016-05-18 02:46:55]

Description was changed from

==========
--

BUG=
==========

to

==========
MacViews: Make buttons not request focus on mouse press.

On Cocoa, buttons never request focus on a mouse press. This CL changes 
CustomButton::set_request_on_press to ensure buttons in MacViews also follow 
this behavior.

BUG=611259
==========

[karandeepb, 2016-05-18 03:46:19]

Patchset #1 (id:1) has been deleted

[karandeepb, 2016-05-18 03:47:07]

karandeepb@chromium.org changed reviewers:
+ sky@chromium.org

[karandeepb, 2016-05-18 03:47:07]

PTAL sky@. Thanks.

[sky, 2016-05-18 16:05:20]

I'm a bit hesitant to enforce this in the constructor. Are you sure there aren't
cases where we want focus on press?

[karandeepb, 2016-05-19 00:15:10]

karandeepb@chromium.org changed reviewers:
+ tapted@chromium.org

[karandeepb, 2016-05-19 00:16:19]

On 2016/05/18 16:05:20, sky wrote:
> I'm a bit hesitant to enforce this in the constructor. Are you sure there
aren't
> cases where we want focus on press?

I experimented with Cocoa UI, and wasn't able to find a case where a button got
focus on a mouse press. Adding Trent, in case he has any more insights/comments.

[tapted, 2016-05-19 05:11:19]

On 2016/05/19 00:16:19, karandeepb wrote:
> On 2016/05/18 16:05:20, sky wrote:
> > I'm a bit hesitant to enforce this in the constructor. Are you sure there
> aren't
> > cases where we want focus on press?
> 
> I experimented with Cocoa UI, and wasn't able to find a case where a button
got
> focus on a mouse press. Adding Trent, in case he has any more
insights/comments.

Yeah I'm pretty sure that it's impossible to focus a native Cocoa button with a
mouse click. Focus always likes to stay on the textfield, regardless of whether
the system 'full keyboard access' setting is on or off. (The WebContent area on
Mac gets this "wrong", but Chrome is consistent with Safari). But also, in
native UI, focus rings tend to animate (scaling down quickly from about double
their size) - doing this on mouse clicks would be distracting.

If a specific View subclass needs it on Mac there are probably things we could
do, but I can't think of a use case for that right now to warrant adding
complexity.

[sky, 2016-05-19 16:27:48]

Ok, LGTM

[karandeepb, 2016-05-19 23:59:02]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-05-19 23:59:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994463002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994463002/40001

[commit-bot: I haz the power, 2016-05-20 03:00:01]

Description was changed from

==========
MacViews: Make buttons not request focus on mouse press.

On Cocoa, buttons never request focus on a mouse press. This CL changes 
CustomButton::set_request_on_press to ensure buttons in MacViews also follow 
this behavior.

BUG=611259
==========

to

==========
MacViews: Make buttons not request focus on mouse press.

On Cocoa, buttons never request focus on a mouse press. This CL changes 
CustomButton::set_request_on_press to ensure buttons in MacViews also follow 
this behavior.

BUG=611259
==========

[commit-bot: I haz the power, 2016-05-20 03:00:02]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-20 03:01:13]

Description was changed from

==========
MacViews: Make buttons not request focus on mouse press.

On Cocoa, buttons never request focus on a mouse press. This CL changes 
CustomButton::set_request_on_press to ensure buttons in MacViews also follow 
this behavior.

BUG=611259
==========

to

==========
MacViews: Make buttons not request focus on mouse press.

On Cocoa, buttons never request focus on a mouse press. This CL changes
CustomButton::set_request_on_press to ensure buttons in MacViews also follow
this behavior.

BUG=611259

Committed: https://crrev.com/3963480dc371af9a4569ac91d982720b66783928
Cr-Commit-Position: refs/heads/master@{#394971}
==========

[commit-bot: I haz the power, 2016-05-20 03:01:16]

Patchset 2 (id:??) landed as
https://crrev.com/3963480dc371af9a4569ac91d982720b66783928
Cr-Commit-Position: refs/heads/master@{#394971}