Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1994463002: MacViews: Make buttons not request focus on mouse press. (Closed)

Created:
4 years, 7 months ago by karandeepb
Modified:
4 years, 7 months ago
Reviewers:
tapted, sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Make buttons not request focus on mouse press. On Cocoa, buttons never request focus on a mouse press. This CL changes CustomButton::set_request_on_press to ensure buttons in MacViews also follow this behavior. BUG=611259 Committed: https://crrev.com/3963480dc371af9a4569ac91d982720b66783928 Cr-Commit-Position: refs/heads/master@{#394971}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ui/views/controls/button/custom_button.h View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
karandeepb
PTAL sky@. Thanks.
4 years, 7 months ago (2016-05-18 03:47:07 UTC) #4
sky
I'm a bit hesitant to enforce this in the constructor. Are you sure there aren't ...
4 years, 7 months ago (2016-05-18 16:05:20 UTC) #5
karandeepb
On 2016/05/18 16:05:20, sky wrote: > I'm a bit hesitant to enforce this in the ...
4 years, 7 months ago (2016-05-19 00:16:19 UTC) #7
tapted
On 2016/05/19 00:16:19, karandeepb wrote: > On 2016/05/18 16:05:20, sky wrote: > > I'm a ...
4 years, 7 months ago (2016-05-19 05:11:19 UTC) #8
sky
Ok, LGTM
4 years, 7 months ago (2016-05-19 16:27:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994463002/40001
4 years, 7 months ago (2016-05-19 23:59:33 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-20 03:00:02 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 03:01:16 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3963480dc371af9a4569ac91d982720b66783928
Cr-Commit-Position: refs/heads/master@{#394971}

Powered by Google App Engine
This is Rietveld 408576698