Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1993973002: Revert "Revert "media: Move widevine CDM targets to WidevineCdm folder"" (Closed)

Created:
4 years, 7 months ago by xhwang
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, msramek+watch_chromium.org, oshima+watch_chromium.org, eme-reviews_chromium.org, grt+watch_chromium.org, raymes+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, wfh+watch_chromium.org, markusheintz_, Michael Moss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This shows the DIFF between old and new changes. Just for your reference. NOT FOR COMMIT

Patch Set 1 : original #

Patch Set 2 : more changes (be aware of a lot of rebase noise) #

Patch Set 3 : add "cdm_paths" target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+510 lines, -99 lines) Patch
M chrome/BUILD.gn View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/content_settings/content_settings_browsertest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/load_library_perf_test.cc View 1 2 chunks +39 lines, -23 lines 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/media/encrypted_media_supported_types_browsertest.cc View 1 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/media/pepper_cdm_test_helper.h View 1 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/media/pepper_cdm_test_helper.cc View 1 3 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser_tests.isolate View 1 3 chunks +54 lines, -10 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/chrome_installer.gypi View 1 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/common/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_paths.cc View 1 3 chunks +4 lines, -1 line 0 comments Download
M chrome/common_constants.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/linux/BUILD.gn View 1 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 1 chunk +7 lines, -1 line 0 comments Download
M chrome/tools/build/win/create_installer_archive.py View 1 3 chunks +3 lines, -2 lines 0 comments Download
M media/BUILD.gn View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
A media/cdm/cdm_paths.h View 1 1 chunk +25 lines, -0 lines 0 comments Download
A media/cdm/cdm_paths.cc View 1 1 chunk +69 lines, -0 lines 0 comments Download
M media/cdm/external_clear_key_test_helper.cc View 1 3 chunks +8 lines, -3 lines 0 comments Download
M media/cdm/ppapi/BUILD.gn View 1 3 chunks +4 lines, -0 lines 0 comments Download
A media/cdm/ppapi/cdm_paths.gni View 1 1 chunk +39 lines, -0 lines 0 comments Download
A media/cdm_paths.gypi View 1 1 chunk +56 lines, -0 lines 0 comments Download
M media/media.gyp View 1 2 2 chunks +21 lines, -0 lines 0 comments Download
M media/media_cdm.gypi View 1 5 chunks +36 lines, -5 lines 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 1 5 chunks +10 lines, -4 lines 0 comments Download
M third_party/widevine/cdm/widevine_cdm.gyp View 1 4 chunks +36 lines, -12 lines 0 comments Download
M third_party/widevine/cdm/widevine_cdm_common.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
xhwang
4 years, 7 months ago (2016-05-24 17:42:05 UTC) #3 
This was only used for showing diffs between and old CL and a new one. Now this
is not needed any more. Closing...

Powered by Google App Engine
This is Rietveld 408576698