Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 1993813002: Revert of media: Add helper function to register pepper CDMs (Closed)

Created:
4 years, 7 months ago by xhwang
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, Nico, ddorwin
CC:
chromium-reviews, mcasas+watch+vc_chromium.org, feature-media-reviews_chromium.org, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media: Add helper function to register pepper CDMs (patchset #4 id:50008 of https://chromiumcodereview.appspot.com/1983563002/ ) Reason for revert: This make tests fail in official builds: https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin%20tester/builds/4758 Original issue's description: > media: Add helper function to register pepper CDMs > > This removes duplicate pepper CDM registration code. > > BUG=610581, 582622 > TEST=No functionality change. > > Committed: https://crrev.com/eb61e1d9dde1d6c02919c3716a2fd6729267cbac > Cr-Commit-Position: refs/heads/master@{#394332} TBR=ddorwin@chromium.org,thestig@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=610581, 582622 Committed: https://crrev.com/0c90dd4e51c054188933aaeffbaceae84f774a18 Cr-Commit-Position: refs/heads/master@{#394440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -136 lines) Patch
M chrome/browser/content_settings/content_settings_browsertest.cc View 5 chunks +54 lines, -10 lines 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 5 chunks +41 lines, -8 lines 0 comments Download
M chrome/browser/media/encrypted_media_supported_types_browsertest.cc View 8 chunks +53 lines, -14 lines 0 comments Download
D chrome/browser/media/pepper_cdm_test_helper.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/media/pepper_cdm_test_helper.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
xhwang
Created Revert of media: Add helper function to register pepper CDMs
4 years, 7 months ago (2016-05-18 16:34:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993813002/1
4 years, 7 months ago (2016-05-18 16:35:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 16:35:45 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 16:36:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c90dd4e51c054188933aaeffbaceae84f774a18
Cr-Commit-Position: refs/heads/master@{#394440}

Powered by Google App Engine
This is Rietveld 408576698