Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: Source/bindings/v8/V8Initializer.cpp

Issue 19932002: Throw exceptions on all failed cross-origin access checks. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: test. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/http/tests/security/xss-eval-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8Initializer.cpp
diff --git a/Source/bindings/v8/V8Initializer.cpp b/Source/bindings/v8/V8Initializer.cpp
index 390723ee5ecfae86653b61a8fc65d0cc292fd7bf..d521b34126f8e733ce1ee598f5ea7df1b29e7677 100644
--- a/Source/bindings/v8/V8Initializer.cpp
+++ b/Source/bindings/v8/V8Initializer.cpp
@@ -104,12 +104,7 @@ static void failedAccessCheckCallbackInMainThread(v8::Local<v8::Object> host, v8
return;
DOMWindow* targetWindow = target->domWindow();
- // Throw an exception for failed-access checks against Location objects, otherwise write to the console.
- WrapperTypeInfo* typeInfo = WrapperTypeInfo::unwrap(data);
- if (V8Location::info.equals(typeInfo))
- setDOMException(SecurityError, targetWindow->crossDomainAccessErrorMessage(activeDOMWindow()), v8::Isolate::GetCurrent());
- else
- targetWindow->printErrorMessage(targetWindow->crossDomainAccessErrorMessage(activeDOMWindow()));
+ setDOMException(SecurityError, targetWindow->crossDomainAccessErrorMessage(activeDOMWindow()), v8::Isolate::GetCurrent());
}
static bool codeGenerationCheckCallbackInMainThread(v8::Local<v8::Context> context)
« no previous file with comments | « LayoutTests/http/tests/security/xss-eval-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698