Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: LayoutTests/http/tests/security/cross-frame-access-object-prototype.html

Issue 19932002: Throw exceptions on all failed cross-origin access checks. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: test. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/security/cross-frame-access-object-prototype.html
diff --git a/LayoutTests/http/tests/security/cross-frame-access-object-prototype.html b/LayoutTests/http/tests/security/cross-frame-access-object-prototype.html
index b1e2110511f1a47a54a95947481ece7f0aaa0c1c..79508645e543656cf4b60907542f9ed8479ff3b5 100644
--- a/LayoutTests/http/tests/security/cross-frame-access-object-prototype.html
+++ b/LayoutTests/http/tests/security/cross-frame-access-object-prototype.html
@@ -42,10 +42,9 @@
log("\n----- test getting values cross-frame using Object.prototype -----\n");
// Attempt to detect values set on the target frame.
- try { shouldBe("Object.prototype.__lookupGetter__.call(targetFrame, 'myGetter');", "undefined"); } catch(e) { log(e); }
- try { shouldBe("Object.prototype.__lookupSetter__.call(targetFrame, 'mySetter');", "undefined"); } catch(e) { log(e); }
-
- try { shouldBe("Object.prototype.propertyIsEnumerable.call(targetFrame, 'myProp');", "false"); } catch(e) { log(e); }
+ try { shouldThrowException("Object.prototype.__lookupGetter__.call(targetFrame, 'myGetter');"); } catch(e) { log(e); }
+ try { shouldThrowException("Object.prototype.__lookupSetter__.call(targetFrame, 'mySetter');"); } catch(e) { log(e); }
+ try { shouldThrowException("Object.prototype.propertyIsEnumerable.call(targetFrame, 'myProp');"); } catch(e) { log(e); }
// FIXME: Unfortunatly, all cross-cross frame calls hasOwnProperty will return true so there is no way to test this right now.
// try { shouldBe("Object.prototype.hasOwnProperty.call(targetFrame, 'myProp');", "false"); } catch(e) { log(e); }

Powered by Google App Engine
This is Rietveld 408576698