[Android Buildbot] Make flakiness dashboard server configurable.

[Android Buildbot] Make flakiness dashboard server configurable.

BUG=263071
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213475

[Siva Chandra, 2013-07-22 20:57:49]

This change will help downstream specify its own flakiness dashboard server.

[frankf, 2013-07-22 21:00:58]

lgtm w/ nit

https://chromiumcodereview.appspot.com/19931004/diff/1/build/android/buildbot...
File build/android/buildbot/bb_device_steps.py (right):

https://chromiumcodereview.appspot.com/19931004/diff/1/build/android/buildbot...
build/android/buildbot/bb_device_steps.py:363: help='Upload the results to the
flakiness dashboard.')
Update the help to something like "Address of the flakiness dashboard server"

[Siva Chandra, 2013-07-22 21:05:05]

https://chromiumcodereview.appspot.com/19931004/diff/1/build/android/buildbot...
File build/android/buildbot/bb_device_steps.py (right):

https://chromiumcodereview.appspot.com/19931004/diff/1/build/android/buildbot...
build/android/buildbot/bb_device_steps.py:363: help='Upload the results to the
flakiness dashboard.')
On 2013/07/22 21:00:58, frankf wrote:
> Update the help to something like "Address of the flakiness dashboard server"

I uploaded patch set 2 with this fixed while you were reviewing patch set 1 I
guess.

[Siva Chandra, 2013-07-22 23:36:31]

I am going to submit this change TBR as frankf@ wants this downstream ASAP.

[commit-bot: I haz the power, 2013-07-22 23:38:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sivachandra@chromium.org/19931004/4001

[Isaac (away), 2013-07-22 23:41:00]

https://chromiumcodereview.appspot.com/19931004/diff/4001/build/android/build...
File build/android/buildbot/bb_run_bot.py (right):

https://chromiumcodereview.appspot.com/19931004/diff/4001/build/android/build...
build/android/buildbot/bb_run_bot.py:19: from pylib import constants
This cannot import constants.  Sorry.

[Siva Chandra, 2013-07-23 00:22:50]

PTaL at patch set 2. I have modified to use the value directly instead of
importing from constants.

[Isaac (away), 2013-07-23 01:49:00]

This is OK but we need to remove the other import of constants too.

Could you remove it in this CL and hardcode 88?

[frankf, 2013-07-23 02:26:45]

On 2013/07/23 01:49:00, Isaac wrote:
> This is OK but we need to remove the other import of constants too.
> 
> Could you remove it in this CL and hardcode 88?

What's the point of duplicating these constants? Note that you're already
indirectly importing constants.py by importing other modules from pylib.

[Isaac (away), 2013-07-23 02:47:41]

I'm not comfortable with our top level buildbot runner having its sys.path
modified.

[Isaac (away), 2013-07-23 02:48:02]

On 2013/07/23 02:47:41, Isaac wrote:
> I'm not comfortable with our top level buildbot runner having its sys.path
> modified.

(this is about the adb path modification)

[Isaac (away), 2013-07-23 02:48:02]

On 2013/07/23 02:47:41, Isaac wrote:
> I'm not comfortable with our top level buildbot runner having its sys.path
> modified.

(this is about the adb path modification)

[frankf, 2013-07-23 03:00:11]

On 2013/07/23 02:48:02, Isaac wrote:
> On 2013/07/23 02:47:41, Isaac wrote:
> > I'm not comfortable with our top level buildbot runner having its sys.path
> > modified.
> 
> (this is about the adb path modification)

There's no sys.path modification, look at:
ADB_PATH = _GetADBPath()

[Siva Chandra, 2013-07-23 19:52:47]

On 2013/07/23 01:49:00, Isaac wrote:
> This is OK but we need to remove the other import of constants too.
> 
> Could you remove it in this CL and hardcode 88?

As is stands today, constants is imported in bb_device_status_check.py,
bb_device_steps.py, bb_host_steps.py and bb_utils.py. Do you want me to remove
all these in this CL?

[Isaac (away), 2013-07-24 08:18:32]

Actually I think this is OK -- you can go back to importing constants at top
level.  The sys.path modification was an older version.

Ideally we would not get this message when importing constants, though "No adb
found in $PATH, fallback to checked in binary."  -- that's in the 'preamble'
section of every buildbot.

[Isaac (away), 2013-07-24 08:19:11]

patchset 2 lgtm

[commit-bot: I haz the power, 2013-07-24 18:39:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sivachandra@chromium.org/19931004/11004

[commit-bot: I haz the power, 2013-07-24 18:41:59]

Change committed as 213475