Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 1992313002: EME: Add milestone to deprecation message for container-only contentType strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/Deprecation.h" 5 #include "core/frame/Deprecation.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/dom/ExecutionContext.h" 8 #include "core/dom/ExecutionContext.h"
9 #include "core/frame/FrameConsole.h" 9 #include "core/frame/FrameConsole.h"
10 #include "core/frame/FrameHost.h" 10 #include "core/frame/FrameHost.h"
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 case UseCounter::ResultsAttribute: 362 case UseCounter::ResultsAttribute:
363 return willBeRemoved("'results' attribute", 53, "5738199536107520"); 363 return willBeRemoved("'results' attribute", 53, "5738199536107520");
364 364
365 case UseCounter::WebAnimationsEasingAsFunctionLinear: 365 case UseCounter::WebAnimationsEasingAsFunctionLinear:
366 return String::format("Specifying animation easing as a function is depr ecated and all support will be removed in %s, at which point this will throw a T ypeError. This warning may have been triggered by the Web Animations or Polymer polyfills. See http://crbug.com/601672 for details.", milestoneString(54)); 366 return String::format("Specifying animation easing as a function is depr ecated and all support will be removed in %s, at which point this will throw a T ypeError. This warning may have been triggered by the Web Animations or Polymer polyfills. See http://crbug.com/601672 for details.", milestoneString(54));
367 367
368 case UseCounter::WindowPostMessageWithLegacyTargetOriginArgument: 368 case UseCounter::WindowPostMessageWithLegacyTargetOriginArgument:
369 return replacedWillBeRemoved("'window.postMessage(message, transferables , targetOrigin)'", "'window.postMessage(message, targetOrigin, transferables)'", 54, "5719033043222528"); 369 return replacedWillBeRemoved("'window.postMessage(message, transferables , targetOrigin)'", "'window.postMessage(message, targetOrigin, transferables)'", 54, "5719033043222528");
370 370
371 case UseCounter::EncryptedMediaAllSelectedContentTypesMissingCodecs: 371 case UseCounter::EncryptedMediaAllSelectedContentTypesMissingCodecs:
372 return "contentType strings without codecs will not be supported by requ estMediaKeySystemAccess() in the future. Please specify the desired codec(s) as part of the contentType."; 372 return String::format("contentType strings without codecs will not be su pported by requestMediaKeySystemAccess() in %s. Please specify the desired codec (s) as part of the contentType.", milestoneString(54));
ddorwin 2016/05/19 19:37:29 Most other messages say "will be removed in," whic
jrummell 2016/05/19 19:52:21 Done.
373 373
374 case UseCounter::V8KeyboardEvent_KeyIdentifier_AttributeGetter: 374 case UseCounter::V8KeyboardEvent_KeyIdentifier_AttributeGetter:
375 return willBeRemoved("'KeyboardEvent.keyIdentifier'", 53, "5316065118650 368"); 375 return willBeRemoved("'KeyboardEvent.keyIdentifier'", 53, "5316065118650 368");
376 376
377 case UseCounter::During_Microtask_Alert: 377 case UseCounter::During_Microtask_Alert:
378 return willBeRemoved("Invoking 'alert()' during microtask execution", 53 , "5647113010544640"); 378 return willBeRemoved("Invoking 'alert()' during microtask execution", 53 , "5647113010544640");
379 379
380 case UseCounter::During_Microtask_Confirm: 380 case UseCounter::During_Microtask_Confirm:
381 return willBeRemoved("Invoking 'confirm()' during microtask execution", 53, "5647113010544640"); 381 return willBeRemoved("Invoking 'confirm()' during microtask execution", 53, "5647113010544640");
382 382
(...skipping 12 matching lines...) Expand all
395 case UseCounter::UntrustedEventDefaultHandled: 395 case UseCounter::UntrustedEventDefaultHandled:
396 return String::format("A DOM event generated from JavaScript has trigger ed a default action inside the browser. This behavior is non-standard and will b e removed in %s. See https://www.chromestatus.com/features/5718803933560832 for more details.", milestoneString(53)); 396 return String::format("A DOM event generated from JavaScript has trigger ed a default action inside the browser. This behavior is non-standard and will b e removed in %s. See https://www.chromestatus.com/features/5718803933560832 for more details.", milestoneString(53));
397 397
398 // Features that aren't deprecated don't have a deprecation message. 398 // Features that aren't deprecated don't have a deprecation message.
399 default: 399 default:
400 return String(); 400 return String();
401 } 401 }
402 } 402 }
403 403
404 } // namespace blink 404 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698