Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 19923006: Test assignment to indexed window properties (Closed)

Created:
7 years, 5 months ago by abarth-chromium
Modified:
7 years, 5 months ago
Reviewers:
adamk
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Test assignment to indexed window properties The actual bug here was fixed in V8, but we should have a test at the Blink layer too. R=adamk BUG=257748 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154714

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
A LayoutTests/http/tests/security/xss-DENIED-window-index-assign.html View 1 chunk +13 lines, -0 lines 2 comments Download
A LayoutTests/http/tests/security/xss-DENIED-window-index-assign-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
7 years, 5 months ago (2013-07-22 22:46:19 UTC) #1
adamk
https://codereview.chromium.org/19923006/diff/1/LayoutTests/http/tests/security/xss-DENIED-window-index-assign.html File LayoutTests/http/tests/security/xss-DENIED-window-index-assign.html (right): https://codereview.chromium.org/19923006/diff/1/LayoutTests/http/tests/security/xss-DENIED-window-index-assign.html#newcode12 LayoutTests/http/tests/security/xss-DENIED-window-index-assign.html:12: <iframe src="data:text/html,<script>alert(parent[0].a);</script><script>parent[0].f();</script>"></iframe><br> Does this load synchronously? If not, you ...
7 years, 5 months ago (2013-07-22 23:19:28 UTC) #2
abarth-chromium
https://codereview.chromium.org/19923006/diff/1/LayoutTests/http/tests/security/xss-DENIED-window-index-assign.html File LayoutTests/http/tests/security/xss-DENIED-window-index-assign.html (right): https://codereview.chromium.org/19923006/diff/1/LayoutTests/http/tests/security/xss-DENIED-window-index-assign.html#newcode12 LayoutTests/http/tests/security/xss-DENIED-window-index-assign.html:12: <iframe src="data:text/html,<script>alert(parent[0].a);</script><script>parent[0].f();</script>"></iframe><br> On 2013/07/22 23:19:28, adamk wrote: > Does ...
7 years, 5 months ago (2013-07-22 23:24:52 UTC) #3
adamk
lgtm
7 years, 5 months ago (2013-07-22 23:38:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/19923006/1
7 years, 5 months ago (2013-07-22 23:59:18 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-23 03:42:13 UTC) #6
Message was sent while issue was closed.
Change committed as 154714

Powered by Google App Engine
This is Rietveld 408576698