Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Unified Diff: sync/engine/commit_processor.cc

Issue 1991973002: [Sync] Add histograms for cookie jar state on Sessions commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl format Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/commit_processor.h ('k') | sync/engine/syncer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/commit_processor.cc
diff --git a/sync/engine/commit_processor.cc b/sync/engine/commit_processor.cc
index 75558ebaa326d110dddff80adc015ff0ff4bd3f7..87e2696e6040bce4b0447a8a054ec507a29764c7 100644
--- a/sync/engine/commit_processor.cc
+++ b/sync/engine/commit_processor.cc
@@ -8,6 +8,7 @@
#include <utility>
+#include "base/metrics/histogram_macros.h"
#include "sync/engine/commit_contribution.h"
#include "sync/engine/commit_contributor.h"
#include "sync/protocol/sync.pb.h"
@@ -24,6 +25,8 @@ CommitProcessor::~CommitProcessor() {}
void CommitProcessor::GatherCommitContributions(
ModelTypeSet commit_types,
size_t max_entries,
+ bool cookie_jar_mismatch,
+ bool cookie_jar_empty,
Commit::ContributionMap* contributions) {
size_t num_entries = 0;
for (ModelTypeSet::Iterator it = commit_types.First();
@@ -42,6 +45,15 @@ void CommitProcessor::GatherCommitContributions(
if (contribution) {
num_entries += contribution->GetNumEntries();
contributions->insert(std::make_pair(it.Get(), std::move(contribution)));
+
+ if (it.Get() == SESSIONS) {
+ UMA_HISTOGRAM_BOOLEAN("Sync.CookieJarMatchOnNavigation",
+ !cookie_jar_mismatch);
+ if (cookie_jar_mismatch) {
+ UMA_HISTOGRAM_BOOLEAN("Sync.CookieJarEmptyOnMismatch",
+ cookie_jar_empty);
+ }
+ }
}
if (num_entries >= max_entries) {
DCHECK_EQ(num_entries, max_entries)
« no previous file with comments | « sync/engine/commit_processor.h ('k') | sync/engine/syncer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698