Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: sync/engine/commit.cc

Issue 1991973002: [Sync] Add histograms for cookie jar state on Sessions commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl format Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/commit.h ('k') | sync/engine/commit_processor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/commit.cc
diff --git a/sync/engine/commit.cc b/sync/engine/commit.cc
index 5e3d72e1d96a7c9b0109e4a3898012f0abe7b9c3..66d0824fdd32c5a9ba31a3d17dfb96f460dbdd6f 100644
--- a/sync/engine/commit.cc
+++ b/sync/engine/commit.cc
@@ -32,21 +32,20 @@ Commit::~Commit() {
DCHECK(cleaned_up_);
}
-Commit* Commit::Init(
- ModelTypeSet requested_types,
- ModelTypeSet enabled_types,
- size_t max_entries,
- const std::string& account_name,
- const std::string& cache_guid,
- bool cookie_jar_mismatch,
- CommitProcessor* commit_processor,
- ExtensionsActivity* extensions_activity) {
+Commit* Commit::Init(ModelTypeSet requested_types,
+ ModelTypeSet enabled_types,
+ size_t max_entries,
+ const std::string& account_name,
+ const std::string& cache_guid,
+ bool cookie_jar_mismatch,
+ bool cookie_jar_empty,
+ CommitProcessor* commit_processor,
+ ExtensionsActivity* extensions_activity) {
// Gather per-type contributions.
ContributionMap contributions;
- commit_processor->GatherCommitContributions(
- requested_types,
- max_entries,
- &contributions);
+ commit_processor->GatherCommitContributions(requested_types, max_entries,
+ cookie_jar_mismatch,
+ cookie_jar_empty, &contributions);
// Give up if no one had anything to commit.
if (contributions.empty())
« no previous file with comments | « sync/engine/commit.h ('k') | sync/engine/commit_processor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698