tools/metrics/histograms/histograms.xml - Issue 1991973002: [Sync] Add histograms for cookie jar state on Sessions commit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1991973002: [Sync] Add histograms for cookie jar state on Sessions commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 1d298733ffeb884c878640b0f0d4f05c494f6148..7f0541cc0e9537085d69da3dd8e736f5eec84a87 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -53819,6 +53819,23 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Sync.CookieJarEmptyOnMismatch" enum="Boolean">

Ilya Sherman 2016/05/18 21:03:01 nit: BooleanEmpty

Nicolas Zea 2016/05/18 22:18:44 Done.

+ <owner>zea@chromium.org</owner>

+ <summary>

+ Whether the gaia cookie jar was empty. Recorded on every SESSIONS commit

+ where the gaia cookie jar does not include the signed in user (

+ CookieJarMismatchOnNavigation == true).

+ </summary>

+</histogram>

+<histogram name="Sync.CookieJarMismatchOnNavigation" enum="Boolean">

Ilya Sherman 2016/05/18 21:03:01 nit: Here as well, please use an enum with more se

Nicolas Zea 2016/05/18 22:18:44 Done.

+ <owner>zea@chromium.org</owner>

+ <summary>

+ Whether the gaia cookie jar included the signed in user or not. Recorded on

+ every SESSIONS commit.

+ </summary>

+</histogram>

<owner>zea@chromium.org</owner>

« no previous file with comments | « sync/sessions/sync_session_context.cc ('k') | no next file » | no next file with comments »