[Sync] Add histograms for cookie jar state on Sessions commit

[Sync] Add histograms for cookie jar state on Sessions commit

On every SESSIONS entity commit, record whether the cookie jar matches
the signed in user. If it doesn't, record also whether the cookie jar was
empty or not.

BUG=599593
Committed: https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3
Cr-Commit-Position: refs/heads/master@{#394624}

[Nicolas Zea, 2016-05-18 19:07:40]

Description was changed from

==========
[Sync] Add histograms for cookie jar state on Sessions commit

On every SESSIONS entity commit, record whether the cookie jar matches
the signed in user. If it doesn't, record also whether the cookie jar was
empty or not.

BUG=none
==========

to

==========
[Sync] Add histograms for cookie jar state on Sessions commit

On every SESSIONS entity commit, record whether the cookie jar matches
the signed in user. If it doesn't, record also whether the cookie jar was
empty or not.

BUG=599593
==========

[Nicolas Zea, 2016-05-18 19:20:35]

zea@chromium.org changed reviewers:
+ isherman@chromium.org, maxbogue@chromium.org

[Nicolas Zea, 2016-05-18 19:20:36]

+Max for review. +Ilya for histograms.

[Ilya Sherman, 2016-05-18 21:03:01]

histograms lgtm % nits:

https://chromiumcodereview.appspot.com/1991973002/diff/20001/tools/metrics/hi...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/1991973002/diff/20001/tools/metrics/hi...
tools/metrics/histograms/histograms.xml:53822: +<histogram
name="Sync.CookieJarEmptyOnMismatch" enum="Boolean">
nit: BooleanEmpty

https://chromiumcodereview.appspot.com/1991973002/diff/20001/tools/metrics/hi...
tools/metrics/histograms/histograms.xml:53831: +<histogram
name="Sync.CookieJarMismatchOnNavigation" enum="Boolean">
nit: Here as well, please use an enum with more semantically meaningful labels.

[maxbogue, 2016-05-18 22:14:49]

lgtm! Just one tiny tiny nit.

https://chromiumcodereview.appspot.com/1991973002/diff/40001/chrome/browser/s...
File chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc
(right):

https://chromiumcodereview.appspot.com/1991973002/diff/40001/chrome/browser/s...
chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc:178:
false, 1);
Nit: this line should be moved right one space (and 180 as well)

[Nicolas Zea, 2016-05-18 22:18:28]

https://codereview.chromium.org/1991973002/diff/40001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc
(right):

https://codereview.chromium.org/1991973002/diff/40001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc:178:
false, 1);
On 2016/05/18 22:14:48, maxbogue wrote:
> Nit: this line should be moved right one space (and 180 as well)

Done.

[Nicolas Zea, 2016-05-18 22:18:44]

https://chromiumcodereview.appspot.com/1991973002/diff/20001/tools/metrics/hi...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/1991973002/diff/20001/tools/metrics/hi...
tools/metrics/histograms/histograms.xml:53822: +<histogram
name="Sync.CookieJarEmptyOnMismatch" enum="Boolean">
On 2016/05/18 21:03:01, Ilya Sherman wrote:
> nit: BooleanEmpty

Done.

https://chromiumcodereview.appspot.com/1991973002/diff/20001/tools/metrics/hi...
tools/metrics/histograms/histograms.xml:53831: +<histogram
name="Sync.CookieJarMismatchOnNavigation" enum="Boolean">
On 2016/05/18 21:03:01, Ilya Sherman wrote:
> nit: Here as well, please use an enum with more semantically meaningful
labels.

Done.

[Nicolas Zea, 2016-05-18 22:18:52]

The CQ bit was checked by zea@chromium.org

[Nicolas Zea, 2016-05-18 22:18:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, maxbogue@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1991973002/#ps60001
(title: "git cl format")

[commit-bot: I haz the power, 2016-05-18 22:19:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1991973002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1991973002/60001

[commit-bot: I haz the power, 2016-05-19 01:07:05]

Description was changed from

==========
[Sync] Add histograms for cookie jar state on Sessions commit

On every SESSIONS entity commit, record whether the cookie jar matches
the signed in user. If it doesn't, record also whether the cookie jar was
empty or not.

BUG=599593
==========

to

==========
[Sync] Add histograms for cookie jar state on Sessions commit

On every SESSIONS entity commit, record whether the cookie jar matches
the signed in user. If it doesn't, record also whether the cookie jar was
empty or not.

BUG=599593
==========

[commit-bot: I haz the power, 2016-05-19 01:07:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-19 01:08:51]

Description was changed from

==========
[Sync] Add histograms for cookie jar state on Sessions commit

On every SESSIONS entity commit, record whether the cookie jar matches
the signed in user. If it doesn't, record also whether the cookie jar was
empty or not.

BUG=599593
==========

to

==========
[Sync] Add histograms for cookie jar state on Sessions commit

On every SESSIONS entity commit, record whether the cookie jar matches
the signed in user. If it doesn't, record also whether the cookie jar was
empty or not.

BUG=599593

Committed: https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3
Cr-Commit-Position: refs/heads/master@{#394624}
==========

[commit-bot: I haz the power, 2016-05-19 01:08:52]

Patchset 4 (id:??) landed as
https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3
Cr-Commit-Position: refs/heads/master@{#394624}