Issue 19915008: [telemetry] Rename Memory benchmark to avoid conflict with Memory measurement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19915008: [telemetry] Rename Memory benchmark to avoid conflict with Memory measurement. (Closed)

Created:
7 years, 5 months ago by dtu

Modified:
7 years, 5 months ago

Reviewers:
tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[telemetry] Rename Memory benchmark to avoid conflict with Memory measurement. Quick fix for now, but I may need to reconsider how run_measurement resolved name conflicts. BUG=263511 TEST=None. R=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213290

Patch Set 1 #

Total comments: 2

Patch Set 2 : Renamee #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tools/perf/benchmarks/memory.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tonyg

lgtm https://codereview.chromium.org/19915008/diff/1/tools/perf/benchmarks/memory.py File tools/perf/benchmarks/memory.py (right): https://codereview.chromium.org/19915008/diff/1/tools/perf/benchmarks/memory.py#newcode9 tools/perf/benchmarks/memory.py:9: class MemoryTop25(test.Test): This is a better name anyway ...

7 years, 5 months ago (2013-07-23 21:33:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/19915008/4001

7 years, 5 months ago (2013-07-23 21:46:06 UTC) #3

Message was sent while issue was closed.

Change committed as 213290

Expand Messages | Collapse Messages