Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: webrtc/audio_receive_stream.h

Issue 1991233004: Moved creation of AudioDecoderFactory to inside PeerConnectionFactory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@audio-decoder-factory-injections-3
Patch Set: Parental Advisory: Explicit Content Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/audio/audio_receive_stream_unittest.cc ('k') | webrtc/call/bitrate_estimator_tests.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_AUDIO_RECEIVE_STREAM_H_ 11 #ifndef WEBRTC_AUDIO_RECEIVE_STREAM_H_
12 #define WEBRTC_AUDIO_RECEIVE_STREAM_H_ 12 #define WEBRTC_AUDIO_RECEIVE_STREAM_H_
13 13
14 #include <map> 14 #include <map>
15 #include <memory> 15 #include <memory>
16 #include <string> 16 #include <string>
17 #include <vector> 17 #include <vector>
18 18
19 #include "webrtc/base/scoped_ref_ptr.h"
20 #include "webrtc/modules/audio_coding/codecs/audio_decoder_factory.h"
19 #include "webrtc/common_types.h" 21 #include "webrtc/common_types.h"
20 #include "webrtc/config.h" 22 #include "webrtc/config.h"
21 #include "webrtc/transport.h" 23 #include "webrtc/transport.h"
22 #include "webrtc/typedefs.h" 24 #include "webrtc/typedefs.h"
23 25
24 namespace webrtc { 26 namespace webrtc {
25
26 class AudioDecoder;
27 class AudioSinkInterface; 27 class AudioSinkInterface;
28 28
29 // WORK IN PROGRESS 29 // WORK IN PROGRESS
30 // This class is under development and is not yet intended for for use outside 30 // This class is under development and is not yet intended for for use outside
31 // of WebRtc/Libjingle. Please use the VoiceEngine API instead. 31 // of WebRtc/Libjingle. Please use the VoiceEngine API instead.
32 // See: https://bugs.chromium.org/p/webrtc/issues/detail?id=4690 32 // See: https://bugs.chromium.org/p/webrtc/issues/detail?id=4690
33 33
34 class AudioReceiveStream { 34 class AudioReceiveStream {
35 public: 35 public:
36 struct Stats { 36 struct Stats {
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 // Identifier for an A/V synchronization group. Empty string to disable. 94 // Identifier for an A/V synchronization group. Empty string to disable.
95 // TODO(pbos): Synchronize streams in a sync group, not just one video 95 // TODO(pbos): Synchronize streams in a sync group, not just one video
96 // stream to one audio stream. Tracked by issue webrtc:4762. 96 // stream to one audio stream. Tracked by issue webrtc:4762.
97 std::string sync_group; 97 std::string sync_group;
98 98
99 // Decoders for every payload that we can receive. Call owns the 99 // Decoders for every payload that we can receive. Call owns the
100 // AudioDecoder instances once the Config is submitted to 100 // AudioDecoder instances once the Config is submitted to
101 // Call::CreateReceiveStream(). 101 // Call::CreateReceiveStream().
102 // TODO(solenberg): Use unique_ptr<> once our std lib fully supports C++11. 102 // TODO(solenberg): Use unique_ptr<> once our std lib fully supports C++11.
103 std::map<uint8_t, AudioDecoder*> decoder_map; 103 std::map<uint8_t, AudioDecoder*> decoder_map;
104
105 rtc::scoped_refptr<AudioDecoderFactory> decoder_factory;
104 }; 106 };
105 107
106 // Starts stream activity. 108 // Starts stream activity.
107 // When a stream is active, it can receive, process and deliver packets. 109 // When a stream is active, it can receive, process and deliver packets.
108 virtual void Start() = 0; 110 virtual void Start() = 0;
109 // Stops stream activity. 111 // Stops stream activity.
110 // When a stream is stopped, it can't receive, process or deliver packets. 112 // When a stream is stopped, it can't receive, process or deliver packets.
111 virtual void Stop() = 0; 113 virtual void Stop() = 0;
112 114
113 virtual Stats GetStats() const = 0; 115 virtual Stats GetStats() const = 0;
114 116
115 // Sets an audio sink that receives unmixed audio from the receive stream. 117 // Sets an audio sink that receives unmixed audio from the receive stream.
116 // Ownership of the sink is passed to the stream and can be used by the 118 // Ownership of the sink is passed to the stream and can be used by the
117 // caller to do lifetime management (i.e. when the sink's dtor is called). 119 // caller to do lifetime management (i.e. when the sink's dtor is called).
118 // Only one sink can be set and passing a null sink clears an existing one. 120 // Only one sink can be set and passing a null sink clears an existing one.
119 // NOTE: Audio must still somehow be pulled through AudioTransport for audio 121 // NOTE: Audio must still somehow be pulled through AudioTransport for audio
120 // to stream through this sink. In practice, this happens if mixed audio 122 // to stream through this sink. In practice, this happens if mixed audio
121 // is being pulled+rendered and/or if audio is being pulled for the purposes 123 // is being pulled+rendered and/or if audio is being pulled for the purposes
122 // of feeding to the AEC. 124 // of feeding to the AEC.
123 virtual void SetSink(std::unique_ptr<AudioSinkInterface> sink) = 0; 125 virtual void SetSink(std::unique_ptr<AudioSinkInterface> sink) = 0;
124 126
125 protected: 127 protected:
126 virtual ~AudioReceiveStream() {} 128 virtual ~AudioReceiveStream() {}
127 }; 129 };
128 } // namespace webrtc 130 } // namespace webrtc
129 131
130 #endif // WEBRTC_AUDIO_RECEIVE_STREAM_H_ 132 #endif // WEBRTC_AUDIO_RECEIVE_STREAM_H_
OLDNEW
« no previous file with comments | « webrtc/audio/audio_receive_stream_unittest.cc ('k') | webrtc/call/bitrate_estimator_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698