Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: samples/third_party/dromaeo/web/Dromaeo.dart

Issue 199003005: Package-ify Dromaeo and browser controller functionality (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: samples/third_party/dromaeo/web/Dromaeo.dart
diff --git a/samples/third_party/dromaeo/Dromaeo.dart b/samples/third_party/dromaeo/web/Dromaeo.dart
similarity index 95%
rename from samples/third_party/dromaeo/Dromaeo.dart
rename to samples/third_party/dromaeo/web/Dromaeo.dart
index d6ed1e6ce9e118c59c2d370714599423622428c1..ec8d97402217573da8852000706a4ad4e0d7276d 100644
--- a/samples/third_party/dromaeo/Dromaeo.dart
+++ b/samples/third_party/dromaeo/web/Dromaeo.dart
@@ -4,6 +4,7 @@ import 'dart:html';
import 'dart:async';
import "dart:convert";
import 'dart:math' as Math;
+import 'dart:js' as js;
import 'Suites.dart';
main() {
@@ -201,6 +202,12 @@ class Dromaeo {
return running;
}
document.body.attributes['class'] = 'alldone';
+ try {
vsm 2014/03/13 22:02:21 The try-catch is a bit ugly here. Consider someth
Emily Fortuna 2014/03/13 22:43:07 Fixed!
+ js.context.callMethod('reportPerformanceTestDone');
+ } catch (e) {
+ // This is not running as a performance test. Continue as normal.
+ window.console.log('Failed to call reportPerformanceTestDone. $e');
+ }
return done;
default:

Powered by Google App Engine
This is Rietveld 408576698