Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: third_party/widevine/cdm/BUILD.gn

Issue 1989893004: media: Use platform specific folders for CDMs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: specify both paths in chrome.release Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/widevine/cdm/BUILD.gn
diff --git a/third_party/widevine/cdm/BUILD.gn b/third_party/widevine/cdm/BUILD.gn
index e2093a58849f6d0cc6965b2e50b158468e05b35a..5d98b3653dfa6fa65a3b14855d0bf93778dc9d2b 100644
--- a/third_party/widevine/cdm/BUILD.gn
+++ b/third_party/widevine/cdm/BUILD.gn
@@ -5,6 +5,7 @@
import("//build/config/chrome_build.gni")
import("//build/config/features.gni")
import("//chrome/version.gni") # TODO layering violation
+import("//media/cdm/ppapi/cdm_paths.gni")
import("//media/cdm/ppapi/ppapi_cdm_adapter.gni")
import("//third_party/widevine/cdm/widevine.gni")
@@ -67,7 +68,7 @@ if (widevine_cdm_binary_files != []) {
copy("widevinecdm") {
sources = widevine_cdm_binary_files
outputs = [
- "$root_out_dir/{{source_file_part}}",
+ "$root_out_dir/$widevine_cdm_path/{{source_file_part}}",
]
# TODO(jrummell)
@@ -77,6 +78,7 @@ if (widevine_cdm_binary_files != []) {
assert(!is_chrome_branded, "Branded Chrome should have binary files to copy.")
assert(!is_android, "Android should not have enable_pepper_cdms.")
shared_library("widevinecdm") {
+ output_dir = "$root_out_dir/$widevine_cdm_path"
sources = [
"//media/cdm/stub/stub_cdm.cc",
"//media/cdm/stub/stub_cdm.h",
@@ -124,6 +126,7 @@ if ((is_chrome_branded || enable_widevine) && enable_pepper_cdms) {
ppapi_cdm_adapter("widevinecdmadapter") {
defines = []
+ output_dir = "$root_out_dir/$widevine_cdm_path"
deps = [
":version_h",
":widevinecdm",
@@ -132,13 +135,16 @@ if ((is_chrome_branded || enable_widevine) && enable_pepper_cdms) {
if (is_linux) {
ldflags =
- [ rebase_path("$root_out_dir/libwidevinecdm.so", root_build_dir) ]
+ [ rebase_path("$root_out_dir/$widevine_cdm_path/libwidevinecdm.so",
+ root_build_dir) ]
} else if (is_win) {
ldflags =
- [ rebase_path("$root_out_dir/widevinecdm.dll.lib", root_build_dir) ]
+ [ rebase_path("$root_out_dir/$widevine_cdm_path/widevinecdm.dll.lib",
+ root_build_dir) ]
} else if (is_mac) {
ldflags =
- [ rebase_path("$root_out_dir/libwidevinecdm.dylib", root_build_dir) ]
+ [ rebase_path("$root_out_dir/$widevine_cdm_path/libwidevinecdm.dylib",
+ root_build_dir) ]
}
}
} else {

Powered by Google App Engine
This is Rietveld 408576698