media/cdm/cdm_paths.h - Issue 1989893004: media: Use platform specific folders for CDMs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/cdm/cdm_paths.h

Issue 1989893004: media: Use platform specific folders for CDMs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix create_installer_archive.py Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef MEDIA_CDM_CDM_PATHS_H_

	6 #define MEDIA_CDM_CDM_PATHS_H_

	7

	8 #include <string>

	9

	10 #include "base/files/file_path.h"

	11

	12 namespace media {

	13

	14 // Returns the relative path of a component CDM. On platforms where a platform
	ddorwin 2016/05/20 04:08:56 Drop "component" from the first sentence. Perhaps Drop "component" from the first sentence. Perhaps also reword to "Returns the path of the \|cdm_base_path\| CDM relative to <modules dir?>." xhwang 2016/05/20 07:18:19 Done, though DIR_COMPONENTS is really a "chrome" c Show quoted text On 2016/05/20 04:08:56, ddorwin wrote: > Drop "component" from the first sentence. > > Perhaps also reword to "Returns the path of the \|cdm_base_path\| CDM relative to > <modules dir?>." Done, though DIR_COMPONENTS is really a "chrome" concept.
	15 // specific path is used, returns

	16 // \|cdm_base_path\|/_platform_specific/<platform>_<arch>

	17 // e.g. WidevineCdm/_platform_specific/win_x64

	18 // Otherwise, returns an empty path.

	19 // TODO(xhwang): Use this function in Widevine CDM component installer.

	20 base::FilePath GetPlatformSpecificDirectory(const std::string& cdm_base_path);

	21

	22 } // namespace media

	23

	24 #endif // MEDIA_CDM_CDM_PATHS_H_

OLD	NEW