Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Side by Side Diff: media/cdm/ppapi/cdm_paths.gni

Issue 1989893004: media: Use platform specific folders for CDMs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 # This file defines output paths for the CDM adapters and CDMs.
6
7 # Naming and folder structure below are following the recommendation for chrome
8 # components. Component-updated CDMs must following the same recommendation.
9
10 # Note: This file must be in sync with cdm_paths.cc
11 # TODO(xhwang): Auto generate paths in C++ from build variables so we don't
12 # need this note.
13
14 # OS name for components is close to "target_os" but has some differences.
15 # Explicitly define what we use to avoid confusion.
16 if (is_chromeos) {
17 component_os = "cros"
18 } else if (is_linux) {
19 component_os = "linux"
20 } else if (is_win) {
21 component_os = "win"
22 } else if (is_mac) {
23 component_os = "mac"
24 } else {
25 component_os = "$target_os"
26 }
27
28 if (is_win || is_mac) {
29 # Architecture name for components is the same as "<(target_cpu)".
30 _platform_specific_path =
31 "_platform_specific/$component_os" + "_" + "$target_cpu"
32
33 # Path of Clear Key and Widevine CDMs relative to the output dir.
34 clearkey_cdm_path = "ClearKeyCdm/$_platform_specific_path"
ddorwin 2016/05/19 00:04:26 Really dir paths
xhwang 2016/05/20 00:22:35 As discussed offline, we'll keep the current names
35 widevine_cdm_path = "WidevineCdm/$_platform_specific_path"
ddorwin 2016/05/19 00:04:26 Could we then add a define that gets used in C++ f
xhwang 2016/05/20 00:22:35 I thought about that but there are issues with tha
36 } else {
37 clearkey_cdm_path = "."
38 widevine_cdm_path = "."
39 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698