Issue 19882003: desktop aura: Fix multiple ibeams in the omnibox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19882003: desktop aura: Fix multiple ibeams in the omnibox. (Closed)

Created:
7 years, 5 months ago by Elliot Glaysher

Modified:
7 years, 5 months ago

Reviewers:
sadrul

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

desktop aura: Fix multiple problems with ibeams in the omnibox. In linux_aura, we must set cursors through the CursorClient interface instead of on the raw RootWindowHost interface because the CursorClient actually sets the system cursor types. In windows aura, we must keep track of the current cursor. We do not and instead always claim that the current cursor is the null cursor. BUG=247180 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213167

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
	M	ui/views/widget/desktop_aura/desktop_native_widget_aura.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	ui/views/widget/desktop_aura/desktop_native_widget_aura.cc	View		4 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/19882003/1

7 years, 5 months ago (2013-07-23 00:25:23 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=150840

7 years, 5 months ago (2013-07-23 02:09:40 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/19882003/1

7 years, 5 months ago (2013-07-23 17:12:06 UTC) #5

Message was sent while issue was closed.

Change committed as 213167

Expand Messages | Collapse Messages