| OLD | NEW |
|---|
| (Empty) | |
| 1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> |
| 2 <html xmlns="http://www.w3.org/1999/xhtml"> |
| 3 <head> |
| 4 <title>Automatically closing tree for "check_deps2git,sizes,update_scripts
,update,compile,gclient_revert,archive_build,runhooks" on "Linux x64"
;</title> |
| 5 </head> |
| 6 <body> |
| 7 <a href="http://build.chromium.org/p/chromium/waterfall/">http://build.chromiu
m.org/p/chromium/waterfall/</a><p> |
| 8 Automatically closing tree for "check_deps2git,sizes,update_scripts,update
,compile,gclient_revert,archive_build,runhooks" on "Linux x64"</p> |
| 9 <a href="http://build.chromium.org/p/chromium/builders/Linux x64/builds/54475"
>http://build.chromium.org/p/chromium/builders/Linux x64/builds/54475</a><p> |
| 10 Revision: 218091, 218092, 218093, 218094<br> |
| 11 Blame list: akalin@chromium.org,lazyboy@chromium.org,noamsml@chromium.org,rmso
usa@chromium.org</p> |
| 12 <table style="border-spacing: 1px 1px; font-weight: bold; padding: 3px 0px 3px 0
px; text-align: center;"> |
| 13 <tr><td style="color: #FFFFFF; background-color: #e0b0ff; border-color: #ACA0B3;
"><a title="Reason: scheduler" href="http://build.chromium.org/p/chromium/waterf
all/builders/Linux%20x64/builds/54475">Build 54475</a></td></tr> <tr><td style="
color: #FFFFFF; background-color: #e0b0ff; border-color: #ACA0B3;"> update_scrip
ts<br/> exception<br/> slave<br/> lost<br/> <a href="http://build.chromium.org/p
/chromium/builders/Linux%20x64/builds/54475/steps/update_scripts/logs/stdio">std
io</a><br/> <a href="http://build.chromium.org/p/chromium/builders/Linux%20x64/b
uilds/54475/steps/update_scripts/logs/interrupt">interrupt</a><br /> </td></tr>
</table> |
| 14 <p> |
| 15 <p>Changed by: <b>noamsml@chromium.org</b><br /> |
| 16 Changed at: <b>Fri 16 Aug 2013 14:20:12</b><br /> |
| 17 Repository: <b>svn://svn-mirror.golo.chromium.org/chrome/trunk</b><br /> |
| 18 |
| 19 Branch: <b>src</b><br /> |
| 20 |
| 21 Revision: <a href="http://src.chromium.org/viewvc/chrome?view=rev&revision=21809
1"><b>218091</b></a> |
| 22 |
| 23 <br /> |
| 24 |
| 25 Changed files: |
| 26 <ul> |
| 27 <li> <b>chrome/browser/local_discovery/service_discovery_host_client.cc</b></li> |
| 28 <li> <b>chrome/browser/local_discovery/service_discovery_host_client.h</b></li> |
| 29 <li> <b>chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc</b
></li> |
| 30 </ul> |
| 31 |
| 32 |
| 33 Comments: |
| 34 <pre>Added singleton factory for ServiceDiscoveryHostClient |
| 35 |
| 36 Added singleton factory for ServiceDiscoveryHostClient so it can be shared |
| 37 between multiple unrelated users. The factory keeps track of references to |
| 38 service discovery and shuts down the client when not used. |
| 39 |
| 40 BUG= |
| 41 |
| 42 Review URL: https://chromiumcodereview.appspot.com/22449004</pre> |
| 43 |
| 44 Properties: |
| 45 <ul> |
| 46 </ul> |
| 47 |
| 48 </p> |
| 49 |
| 50 <p>Changed by: <b>lazyboy@chromium.org</b><br /> |
| 51 Changed at: <b>Fri 16 Aug 2013 14:20:12</b><br /> |
| 52 Repository: <b>svn://svn-mirror.golo.chromium.org/chrome/trunk</b><br /> |
| 53 |
| 54 Branch: <b>src</b><br /> |
| 55 |
| 56 Revision: <a href="http://src.chromium.org/viewvc/chrome?view=rev&revision=21809
2"><b>218092</b></a> |
| 57 |
| 58 <br /> |
| 59 |
| 60 Changed files: |
| 61 <ul> |
| 62 <li> <b>chrome/browser/apps/web_view_browsertest.cc</b></li> |
| 63 <li> <b>chrome/test/data/extensions/platform_apps/web_view/interstitial_teardown
</b></li> |
| 64 <li> <b>chrome/test/data/extensions/platform_apps/web_view/interstitial_teardown
/embedder.js</b></li> |
| 65 <li> <b>chrome/test/data/extensions/platform_apps/web_view/interstitial_teardown
/https_page.html</b></li> |
| 66 <li> <b>chrome/test/data/extensions/platform_apps/web_view/interstitial_teardown
/main.html</b></li> |
| 67 <li> <b>chrome/test/data/extensions/platform_apps/web_view/interstitial_teardown
/manifest.json</b></li> |
| 68 <li> <b>chrome/test/data/extensions/platform_apps/web_view/interstitial_teardown
/test.js</b></li> |
| 69 <li> <b>content/browser/browser_plugin/browser_plugin_guest.cc</b></li> |
| 70 <li> <b>content/browser/browser_plugin/browser_plugin_guest.h</b></li> |
| 71 <li> <b>content/browser/renderer_host/render_widget_host_view_guest.cc</b></li> |
| 72 </ul> |
| 73 |
| 74 |
| 75 Comments: |
| 76 <pre><webview>: Fix ptr access crash on browser plugin + interstitial tear
down. |
| 77 |
| 78 If browser plugin loaded an interstitial page as view contents |
| 79 (e.g. loading plugin resulted in ssl-error), upon closing the |
| 80 containing app, the interstitial would try to show back |
| 81 (RenderWidgetHostView::WasShown) the original contents of the |
| 82 RWHViewGuest, whose render_view_host_ was already in the middle of |
| 83 destruction. We record the destruction phase and avoid calling methods |
| 84 on RenderViewHost in this case. |
| 85 |
| 86 BUG=270313 |
| 87 TEST=chrome app <webview>, load a guest pointing a page that results in |
| 88 ssl-error page showing (Proceed to safety page, etc), close the app. The app |
| 89 would crash without this change. |
| 90 Added regression test. |
| 91 |
| 92 Review URL: https://chromiumcodereview.appspot.com/23004002</pre> |
| 93 |
| 94 Properties: |
| 95 <ul> |
| 96 </ul> |
| 97 |
| 98 </p> |
| 99 |
| 100 <p>Changed by: <b>akalin@chromium.org</b><br /> |
| 101 Changed at: <b>Fri 16 Aug 2013 14:25:12</b><br /> |
| 102 Repository: <b>svn://svn-mirror.golo.chromium.org/chrome/trunk</b><br /> |
| 103 |
| 104 Branch: <b>src</b><br /> |
| 105 |
| 106 Revision: <a href="http://src.chromium.org/viewvc/chrome?view=rev&revision=21809
3"><b>218093</b></a> |
| 107 |
| 108 <br /> |
| 109 |
| 110 Changed files: |
| 111 <ul> |
| 112 <li> <b>chrome/browser/devtools/tethering_adb_filter.cc</b></li> |
| 113 <li> <b>chrome/browser/extensions/api/dns/dns_api.cc</b></li> |
| 114 <li> <b>chrome/browser/extensions/api/socket/socket_api.cc</b></li> |
| 115 <li> <b>chrome/browser/net/network_stats.cc</b></li> |
| 116 <li> <b>chrome/browser/net/predictor.cc</b></li> |
| 117 <li> <b>content/browser/renderer_host/p2p/socket_dispatcher_host.cc</b></li> |
| 118 <li> <b>content/browser/renderer_host/pepper/pepper_host_resolver_message_filter
.cc</b></li> |
| 119 <li> <b>content/browser/renderer_host/pepper/pepper_tcp_socket.cc</b></li> |
| 120 <li> <b>net/dns/host_resolver.cc</b></li> |
| 121 <li> <b>net/dns/host_resolver.h</b></li> |
| 122 <li> <b>net/dns/host_resolver_impl_unittest.cc</b></li> |
| 123 <li> <b>net/dns/mapped_host_resolver_unittest.cc</b></li> |
| 124 <li> <b>net/dns/single_request_host_resolver_unittest.cc</b></li> |
| 125 <li> <b>net/ftp/ftp_network_transaction.cc</b></li> |
| 126 <li> <b>net/http/http_auth_handler_negotiate.cc</b></li> |
| 127 <li> <b>net/http/http_network_transaction_unittest.cc</b></li> |
| 128 <li> <b>net/proxy/proxy_resolver_v8_tracing.cc</b></li> |
| 129 <li> <b>net/quic/quic_network_transaction_unittest.cc</b></li> |
| 130 <li> <b>net/quic/quic_stream_factory.cc</b></li> |
| 131 <li> <b>net/socket/socks5_client_socket_unittest.cc</b></li> |
| 132 <li> <b>net/socket/socks_client_socket_pool.cc</b></li> |
| 133 <li> <b>net/socket/socks_client_socket_unittest.cc</b></li> |
| 134 <li> <b>net/socket/ssl_client_socket_pool_unittest.cc</b></li> |
| 135 <li> <b>net/socket/transport_client_socket_pool.cc</b></li> |
| 136 <li> <b>net/socket/transport_client_socket_pool.h</b></li> |
| 137 <li> <b>net/socket/transport_client_socket_unittest.cc</b></li> |
| 138 <li> <b>net/socket_stream/socket_stream.cc</b></li> |
| 139 <li> <b>net/spdy/spdy_session_pool.cc</b></li> |
| 140 <li> <b>net/spdy/spdy_session_pool_unittest.cc</b></li> |
| 141 <li> <b>net/spdy/spdy_session_unittest.cc</b></li> |
| 142 <li> <b>net/test/spawned_test_server/base_test_server.cc</b></li> |
| 143 <li> <b>net/tools/gdig/gdig.cc</b></li> |
| 144 </ul> |
| 145 |
| 146 |
| 147 Comments: |
| 148 <pre>Add a priority parameter for HostResolver::RequestInfo's constructor |
| 149 |
| 150 Use DEFAULT_PRIORITY when there isn't already a priority |
| 151 available. |
| 152 |
| 153 This has the net effect of changing the priority of |
| 154 host resolver requests that didn't specify one from |
| 155 MEDIUM to DEFAULT_PRIORITY (= LOWEST). This is okay, |
| 156 as those requests apparently didn't care what priority |
| 157 they wanted. |
| 158 |
| 159 BUG=166689 |
| 160 TBR=mmenke@chromium.org |
| 161 |
| 162 Review URL: https://codereview.chromium.org/23146004</pre> |
| 163 |
| 164 Properties: |
| 165 <ul> |
| 166 </ul> |
| 167 |
| 168 </p> |
| 169 |
| 170 <p>Changed by: <b>rmsousa@chromium.org</b><br /> |
| 171 Changed at: <b>Fri 16 Aug 2013 14:29:12</b><br /> |
| 172 Repository: <b>svn://svn-mirror.golo.chromium.org/chrome/trunk</b><br /> |
| 173 |
| 174 Branch: <b>src</b><br /> |
| 175 |
| 176 Revision: <a href="http://src.chromium.org/viewvc/chrome?view=rev&revision=21809
4"><b>218094</b></a> |
| 177 |
| 178 <br /> |
| 179 |
| 180 Changed files: |
| 181 <ul> |
| 182 <li> <b>remoting/host/setup/native_messaging_host.cc</b></li> |
| 183 <li> <b>remoting/host/setup/native_messaging_host.h</b></li> |
| 184 <li> <b>remoting/host/setup/native_messaging_host_unittest.cc</b></li> |
| 185 <li> <b>remoting/host/setup/oauth_client.cc</b></li> |
| 186 <li> <b>remoting/host/setup/oauth_client.h</b></li> |
| 187 <li> <b>remoting/remoting.gyp</b></li> |
| 188 <li> <b>remoting/webapp/host_controller.js</b></li> |
| 189 <li> <b>remoting/webapp/host_dispatcher.js</b></li> |
| 190 <li> <b>remoting/webapp/host_native_messaging.js</b></li> |
| 191 </ul> |
| 192 |
| 193 |
| 194 Comments: |
| 195 <pre>Native messaging support for service accounts. |
| 196 |
| 197 This is an alternative implementation of https://codereview.chromium.org/1967002
1/ . This version performs the OAuth token exchange steps from inside the Native
Messaging host. This means that the client secret and the service account access
token never leave the native messaging host. |
| 198 |
| 199 Since the API keys are also needed to use the refresh token, this means that onl
y the host binaries are able to get an access token for the service account. |
| 200 |
| 201 BUG=224742 |
| 202 |
| 203 Review URL: https://chromiumcodereview.appspot.com/22769002</pre> |
| 204 |
| 205 Properties: |
| 206 <ul> |
| 207 </ul> |
| 208 |
| 209 </p> |
| 210 </body> |
| 211 </html> |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 19878007:
Add build mailer capability to support gatekeeper_ng. (Closed)
Base URL: https://chromium.googlesource.com/chromium/tools/chromium-build@master