Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 19872007: Use process per site instance for "Instant". (Closed)

Created:
7 years, 5 months ago by kmadhusu
Modified:
7 years, 5 months ago
Reviewers:
samarth
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, mad+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Visibility:
Public.

Description

Use process per site instance for "Instant". BUG=259498 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213344

Patch Set 1 : '' #

Total comments: 4

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -91 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/instant_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/search/search.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/search/search.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/search/search_unittest.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 3 chunks +91 lines, -90 lines 0 comments Download
M chrome/browser/ui/search/instant_ntp_prerenderer.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kmadhusu
Please review. Thanks.
7 years, 5 months ago (2013-07-23 22:09:28 UTC) #1
samarth
lgtm https://codereview.chromium.org/19872007/diff/5001/chrome/browser/search/search.h File chrome/browser/search/search.h (right): https://codereview.chromium.org/19872007/diff/5001/chrome/browser/search/search.h#newcode79 chrome/browser/search/search.h:79: bool ShouldInstantURLUseProcessPerSite(const GURL& url, Profile* profile); How about ...
7 years, 5 months ago (2013-07-23 23:44:02 UTC) #2
kmadhusu
Addressed comments. Thanks. https://chromiumcodereview.appspot.com/19872007/diff/5001/chrome/browser/search/search.h File chrome/browser/search/search.h (right): https://chromiumcodereview.appspot.com/19872007/diff/5001/chrome/browser/search/search.h#newcode79 chrome/browser/search/search.h:79: bool ShouldInstantURLUseProcessPerSite(const GURL& url, Profile* profile); ...
7 years, 5 months ago (2013-07-24 00:36:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/19872007/13008
7 years, 5 months ago (2013-07-24 00:38:50 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 04:56:10 UTC) #5
Message was sent while issue was closed.
Change committed as 213344

Powered by Google App Engine
This is Rietveld 408576698