chrome/browser/chromeos/login/captive_portal_view.cc - Issue 19869003: ChromeOS changes for GetURL refactor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/captive_portal_view.cc

Issue 19869003: ChromeOS changes for GetURL refactor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing failing tests. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/captive_portal_view.cc

diff --git a/chrome/browser/chromeos/login/captive_portal_view.cc b/chrome/browser/chromeos/login/captive_portal_view.cc

index 5f5267205cb7aec5010448144f25fc8c9d118127..c61b7a3e6caecb16376ff961574efb09c9e34d04 100644

--- a/chrome/browser/chromeos/login/captive_portal_view.cc

+++ b/chrome/browser/chromeos/login/captive_portal_view.cc

@@ -70,7 +70,7 @@ void CaptivePortalView::NavigationStateChanged(

// Naive way to determine the redirection. This won't be needed after portal

// detection will be done on the Chrome side.

- GURL url = source->GetURL();

+ GURL url = source->GetLastCommittedURL();

// Note, |url| will be empty for "client3.google.com/generate_204" page.

if (!redirected_ && url != GURL::EmptyGURL() &&

url != GURL(CaptivePortalStartURL())) {