Issue 19869003: ChromeOS changes for GetURL refactor.

Issue 19869003: ChromeOS changes for GetURL refactor. (Closed)

Created:
7 years, 5 months ago by nasko

Modified:
7 years, 4 months ago

Reviewers:
satorux1

CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, feature-media-reviews_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ChromeOS changes for GetURL refactor. The GetURL method doesn't cover the different use cases for it, so it is being split up and the original will be removed. This CL is converting ChromeOS code to use the proper version of WebContents::GetURL API. BUG=237908 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214766

Patch Set 1 #

Patch Set 2 : Leave ChromeOS changes only. #

Patch Set 3 : Fix unit tests. #

Patch Set 4 : Fixing failing tests. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -11 lines)			Patch
M	chrome/browser/chromeos/boot_times_loader.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/dbus/printer_service_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/captive_portal_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/merge_session_load_page_unittest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/media/media_player.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/memory/oom_priority_manager.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/offline/offline_load_page_unittest.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/policy/device_local_account_browsertest.cc	View	1 2 3	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

nasko

I've made a couple of changes due to failing tests. Please take a look to ...

7 years, 4 months ago (2013-07-29 23:11:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/19869003/24001

7 years, 4 months ago (2013-07-31 14:42:14 UTC) #4

Message was sent while issue was closed.

Change committed as 214766

Expand Messages | Collapse Messages