GCP2.0 Device: Receiving printjobs.

cloud_print/gcp20/prototype/cloud_print_request.cc

Index: cloud_print/gcp20/prototype/cloud_print_request.cc
diff --git a/cloud_print/gcp20/prototype/cloud_print_request.cc b/cloud_print/gcp20/prototype/cloud_print_request.cc
new file mode 100644
index 0000000000000000000000000000000000000000..07cdf246a39ce1a5d5ec3896ae7fc63d73da0fc8
--- /dev/null
+++ b/cloud_print/gcp20/prototype/cloud_print_request.cc
@@ -0,0 +1,124 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "cloud_print/gcp20/prototype/cloud_print_request.h"
+
+#include "base/bind.h"
+#include "base/message_loop/message_loop.h"
+#include "base/strings/stringprintf.h"
+#include "base/time/time.h"
+#include "net/base/load_flags.h"
+#include "net/http/http_status_code.h"
+#include "net/url_request/url_request_context.h"
+#include "net/url_request/url_request_context_getter.h"
+
+CloudPrintRequest::CloudPrintRequest(Delegate* delegate): delegate_(delegate) {
+}
+
+CloudPrintRequest::~CloudPrintRequest() {
+}
+
+using net::URLFetcher;
+using base::MessageLoop;
+
+namespace {
+
+const uint32 kDefaultTimeout = 20;  // in seconds
+
+}  // namespace
+
+scoped_ptr<CloudPrintRequest> CloudPrintRequest::CreateGet(
+    const GURL& url,
+    Delegate* delegate) {
+  return CreateRequest(url, URLFetcher::GET, delegate);
+}
+
+scoped_ptr<CloudPrintRequest> CloudPrintRequest::CreatePost(
+    const GURL& url,
+    const DataForUpload& data,
+    Delegate* delegate) {
+  scoped_ptr<CloudPrintRequest> request =
+      CreateRequest(url, URLFetcher::POST, delegate);
+  request->fetcher_->SetUploadData(data.content_type, data.content);
+  return request.Pass();
+}
+
+void CloudPrintRequest::Run(const ParserCallback& parser) {
+  DCHECK(!parser.is_null());
+
+  std::string access_token = delegate_->access_token();
+  if (!access_token.empty())
+    fetcher_->AddExtraRequestHeader(base::StringPrintf(
+        "Authorization: Bearer \"%s\"", access_token.c_str()));
+
+  parser_ = parser;
+  fetcher_->SetRequestContext(delegate_->context_getter());
+  fetcher_->Start();
+
+  MessageLoop::current()->PostDelayedTask(
+      FROM_HERE,
+      base::Bind(&CloudPrintRequest::OnRequestTimeout, this->AsWeakPtr()),
+      base::TimeDelta::FromSeconds(kDefaultTimeout));
+}
+
+void CloudPrintRequest::AddHeader(const std::string& header) {
+  fetcher_->AddExtraRequestHeader(header);
+}
+
+void CloudPrintRequest::OnRequestTimeout() {
+  if (!fetcher_)
+    return;
+
+  LOG(WARNING) << "Request timeout reached.";
+  MessageLoop::current()->PostTask(
+      FROM_HERE,
+      base::Bind(&CloudPrintRequest::Delegate::OnFetchTimeoutReached,
+                 base::Unretained(delegate_)));

[Vitaly Buka (NO REVIEWS), 2013/07/22 03:57:31]

That's incorrect.
Here you post task with plain pointer to delegate. Nothing prevents task from
beeing executed after delegate is deleted.

[maksymb, 2013/07/22 22:56:53]

Done.

+  fetcher_.reset();
+}
+
+void CloudPrintRequest::OnURLFetchComplete(const URLFetcher* source) {
+  DCHECK(source == fetcher_.get());
+  std::string response;
+  source->GetResponseAsString(&response);
+
+  int http_code = fetcher_->GetResponseCode();
+
+  if (http_code == net::HTTP_OK) {
+    MessageLoop::current()->PostTask(
+        FROM_HERE,

[Vitaly Buka (NO REVIEWS), 2013/07/22 03:57:31]

Same here.

[maksymb, 2013/07/22 22:56:53]

Done.

+        base::Bind(&CloudPrintRequest::Delegate::OnFetchComplete,
+                   base::Unretained(delegate_)));
+    MessageLoop::current()->PostTask(FROM_HERE, base::Bind(parser_, response));

[Vitaly Buka (NO REVIEWS), 2013/07/22 03:57:31]

Similar for parser_.
Caller should expect that parser_ will not be called if CreateRequest is
deleted. It's not true for this code.

[maksymb, 2013/07/22 22:56:53]

Done.

+  } else {
+    MessageLoop::current()->PostTask(
+            FROM_HERE,
+            base::Bind(&CloudPrintRequest::Delegate::OnFetchError,

[Vitaly Buka (NO REVIEWS), 2013/07/22 03:57:31]

Same.

[maksymb, 2013/07/22 22:56:53]

Done.

+                       base::Unretained(delegate_), "dummy", -1, http_code));
+    // TODO(maksymb): Add |server_http_code| and |server_api| info for errors.
+    NOTIMPLEMENTED() << "HTTP code: " << http_code;

[Vitaly Buka (NO REVIEWS), 2013/07/22 03:57:31]

I'd recoment to PostTask only  for CloudPrintRequest:: methods and user WeakPtr

[maksymb, 2013/07/22 22:56:53]

Done.

+  }
+
+  fetcher_.reset();
+  VLOG(3) << response;
+}
+
+scoped_ptr<CloudPrintRequest> CloudPrintRequest::CreateRequest(
+    const GURL& url,
+    URLFetcher::RequestType method,
+    Delegate* delegate) {
+  scoped_ptr<CloudPrintRequest> request(new CloudPrintRequest(delegate));
+
+  request->fetcher_.reset(URLFetcher::Create(url, method, request.get()));
+
+  int load_flags = request->fetcher_->GetLoadFlags();
+  load_flags |= net::LOAD_DO_NOT_SEND_COOKIES;
+  load_flags |= net::LOAD_DO_NOT_SAVE_COOKIES;
+  request->fetcher_->SetLoadFlags(load_flags);
+
+  request->fetcher_->AddExtraRequestHeader("X-CloudPrint-Proxy: \"\"");
+
+  return request.Pass();
+}
+