Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19865002: [CSS Shapes] Port shape-inside on regions and shape's content overflow from WebKit (Closed)

Created:
7 years, 5 months ago by Zoltan
Modified:
7 years, 4 months ago
Reviewers:
eric, eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, chromiumbugtracker_adobe.com, leviw+renderwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : [CSS Shapes] Port shape-inside on regions and shape's content overflow from WebKit #

Patch Set 3 : [CSS Shapes] Port shape-inside on regions and shape's content overflow from WebKit #

Patch Set 4 : [CSS Shapes] Port shape-inside on regions and shape's content overflow from WebKit #

Patch Set 5 : [CSS Shapes] Port shape-inside on regions and shape's content overflow from WebKit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1933 lines, -258 lines) Patch
M LayoutTests/fast/regions/shape-inside/shape-inside-on-additional-regions.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-additional-regions-expected.html View 2 chunks +9 lines, -7 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-first-region-block-content.html View 1 chunk +48 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-first-region-block-content-expected.html View 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-first-region-inline-content.html View 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-first-region-inline-content-expected.html View 1 chunk +38 lines, -0 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-regions.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-block-content-basic-overflow-shape-top-offset.html View 1 chunk +44 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-block-content-basic-overflow-shape-top-offset-expected.html View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes.html View 1 chunk +59 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes-expected.html View 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html View 1 chunk +59 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes-expected.html View 1 chunk +53 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-block-content-polygon-with-adjustment.html View 1 chunk +47 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-block-content-polygon-with-adjustment-expected.html View 1 chunk +46 lines, -0 lines 0 comments Download
M LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-expected.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-inline-content.html View 2 chunks +12 lines, -11 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-inline-content-basic-overflow-shape-top-offset.html View 1 chunk +44 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-inline-content-basic-overflow-shape-top-offset-expected.html View 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-inline-content-expected.html View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes.html View 1 chunk +59 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes-expected.html View 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-multiple-shapes.html View 1 chunk +58 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-multiple-shapes-expected.html View 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-inline-content-polygon-with-adjustment.html View 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-regions-inline-content-polygon-with-adjustment-expected.html View 1 chunk +44 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-second-region-block-content.html View 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-second-region-block-content-expected.html View 1 chunk +47 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-second-region-inline-content.html View 1 chunk +47 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-on-second-region-inline-content-expected.html View 1 chunk +43 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-with-region-borders.html View 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-with-region-borders-expected.html View 1 chunk +43 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-with-region-padding.html View 1 chunk +47 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/shape-inside/shape-inside-with-region-padding-expected.html View 1 chunk +31 lines, -0 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-bottom-edge.html View 1 2 1 chunk +50 lines, -33 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-bottom-edge-expected.html View 1 2 1 chunk +44 lines, -30 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-empty.html View 1 2 3 chunks +25 lines, -18 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-empty-expected.html View 1 2 1 chunk +34 lines, -30 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-overflow.html View 1 2 3 1 chunk +12 lines, -17 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-overflow-expected.html View 1 2 3 1 chunk +14 lines, -17 lines 0 comments Download
A LayoutTests/fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions.html View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A LayoutTests/fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
A LayoutTests/fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-block-content-expected.html View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
A LayoutTests/fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-percentage.html View 1 2 2 chunks +7 lines, -10 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-percentage-expected.html View 1 2 2 chunks +10 lines, -3 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-recursive-layout.html View 1 2 3 chunks +3 lines, -18 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-recursive-layout-expected.html View 1 2 3 chunks +3 lines, -18 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rounded-rectangle-004.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/shapes/shape-inside/shape-inside-rounded-rectangle-004-expected.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 2 3 10 chunks +153 lines, -23 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 2 3 1 chunk +6 lines, -3 lines 0 comments Download
M Source/core/rendering/shapes/ShapeInfo.h View 3 chunks +6 lines, -3 lines 0 comments Download
M Source/core/rendering/shapes/ShapeInfo.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
eseidel
lgtm
7 years, 5 months ago (2013-07-25 23:25:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zoltan@adobe.com/19865002/5001
7 years, 5 months ago (2013-07-25 23:29:01 UTC) #2
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=18495
7 years, 5 months ago (2013-07-26 02:04:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zoltan@adobe.com/19865002/27001
7 years, 5 months ago (2013-07-26 20:49:00 UTC) #4
commit-bot: I haz the power
Failed to trigger a try job on blink_presubmit HTTP Error 400: Bad Request
7 years, 5 months ago (2013-07-26 21:06:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zoltan@adobe.com/19865002/32001
7 years, 5 months ago (2013-07-26 21:06:54 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=14973
7 years, 5 months ago (2013-07-27 01:46:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zoltan@adobe.com/19865002/32001
7 years, 4 months ago (2013-07-29 16:00:17 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-07-29 20:15:53 UTC) #9
Message was sent while issue was closed. 
Change committed as 155098

Powered by Google App Engine
This is Rietveld 408576698