Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Issue 1986233002: Temporarily enable hang report capture (Closed)

Created:
4 years, 7 months ago by manzagop (departed)
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily enable hang report capture Overview: Browser process hangs are believed to be responsible for a large fraction of browser unclean shutdowns on Windows. This patch enables hang report capture to get visibility into the problem. Note: - This is a follow up to a previous ship: https://codereview.chromium.org/1891563002/ - Capture only occurs on canary Chrome for users with stats consent. - The plan is to release for a single day. BUG=478209, 585953 Committed: https://crrev.com/bdfbf2514ead1bf337613ac79864f021c5e6e737 Cr-Commit-Position: refs/heads/master@{#395970}

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M build/common.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/kasko/kasko.gni View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
manzagop (departed)
Hi pmonette@, Could you have a look? Thanks! Pierre
4 years, 7 months ago (2016-05-17 15:51:01 UTC) #2
manzagop (departed)
Friendly ping!
4 years, 7 months ago (2016-05-24 15:01:56 UTC) #3
Patrick Monette
lgtm
4 years, 7 months ago (2016-05-24 15:48:56 UTC) #5
manzagop (departed)
Hi dpranke@, I'm looking for OWNERS' approval on this CL which enables hang detection on ...
4 years, 7 months ago (2016-05-24 16:03:42 UTC) #7
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-24 18:54:10 UTC) #9
manzagop (departed)
Thanks for the review! I have the green light for today. Committing.
4 years, 7 months ago (2016-05-25 18:25:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1986233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1986233002/20001
4 years, 7 months ago (2016-05-25 18:25:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 20:05:53 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bdfbf2514ead1bf337613ac79864f021c5e6e737 Cr-Commit-Position: refs/heads/master@{#395970}
4 years, 7 months ago (2016-05-25 20:08:37 UTC) #16
manzagop (departed)
4 years, 7 months ago (2016-05-26 13:10:36 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://chromiumcodereview.appspot.com/2010993003/ by manzagop@chromium.org.

The reason for reverting is: Single day experiment..

Powered by Google App Engine
This is Rietveld 408576698