url/gurl.cc - Issue 19857005: Do not show translate bar for MHTML files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: url/gurl.cc

Issue 19857005: Do not show translate bar for MHTML files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add and use GURL::ExtractFileExtension() Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: url/gurl.cc

diff --git a/url/gurl.cc b/url/gurl.cc

index 3dd8463c658b243ccef5d5ddabeb51215f1e1197..69fcfc29f1bbc00e1bb9bf0b1e349becb93a05b9 100644

--- a/url/gurl.cc

+++ b/url/gurl.cc

@@ -374,6 +374,13 @@ std::string GURL::ExtractFileName() const {

return ComponentString(file_component);

}

+std::string GURL::ExtractFileExtension() const {

+ url_parse::Component file_extension_component;

+ url_parse::ExtractFileExtension(spec_.data(), parsed_.path,

+ &file_extension_component);

+ return ComponentString(file_extension_component);

std::string GURL::PathForRequest() const {

DCHECK(parsed_.path.len > 0) << "Canonical path for requests should be non-empty";

if (parsed_.ref.len >= 0) {