Do not show translate bar for MHTML files.

chrome/browser/translate/translate_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/translate/translate_manager.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram.h"
@@ skipping 63 matching lines @@
 const char kUrlQueryName[] = "u";
 
 // The delay in ms that we'll wait to check if a page has finished loading
 // before attempting a translation.
 const int kTranslateLoadCheckDelayMs = 150;
 
 // The maximum number of attempts we'll do to see if the page has finshed
 // loading before giving up the translation
 const int kMaxTranslateLoadCheckAttempts = 20;
 
+// file extensions tested for in IsTranslatableURL()
+const char kFileExtMHTMLShort[] = "mht";
+const char kFileExtMHTMLLong[] = "mhtml";
+
 }  // namespace
 
 TranslateManager::~TranslateManager() {
   weak_method_factory_.InvalidateWeakPtrs();
 }
 
 // static
 TranslateManager* TranslateManager::GetInstance() {
   return Singleton<TranslateManager>::get();
 }
 
 // static
 bool TranslateManager::IsTranslatableURL(const GURL& url) {
   // A URLs is translatable unless it is one of the following:
   // - empty (can happen for popups created with window.open(""))
   // - an internal URL (chrome:// and others)
   // - the devtools (which is considered UI)
   // - Chrome OS file manager extension
   // - an FTP page (as FTP pages tend to have long lists of filenames that may
   //   confuse the CLD)
+  // - an MHTML page (Chrome does not load external resources when displaying
+  //   MHTML pages, see bug 262953)
+
+  // extract file extension (empty if URL does not reference a file)
+  std::string file_extension = url.ExtractFileExtension();
+
   return !url.is_empty() &&
          !url.SchemeIs(chrome::kChromeUIScheme) &&
          !url.SchemeIs(chrome::kChromeDevToolsScheme) &&
 #ifdef FILE_MANAGER_EXTENSION
          !(url.SchemeIs(extensions::kExtensionScheme) &&
            url.DomainIs(kFileBrowserDomain)) &&
 #endif
-         !url.SchemeIs(chrome::kFtpScheme);
+         !url.SchemeIs(chrome::kFtpScheme) &&
+         !(file_extension.compare(kFileExtMHTMLShort) == 0 ||

[MAD, 2013/07/29 20:39:17]

Shouldn't we do a case insensitive compare?

+           file_extension.compare(kFileExtMHTMLLong) == 0);
 }
 
 // static
 void TranslateManager::GetSupportedLanguages(
     std::vector<std::string>* languages) {
   if (GetInstance()->language_list_.get()) {
     GetInstance()->language_list_->GetSupportedLanguages(languages);
     return;
   }
   NOTREACHED();
@@ skipping 595 matching lines @@
   // so we are more aggressive about showing the shortcut to never translate.
   #if defined(OS_ANDROID)
   config.never_translate_min_count = 1;
   #else
   config.never_translate_min_count = 3;
   #endif  // defined(OS_ANDROID)
 
   config.always_translate_min_count = 3;
   return config;
 }