tools/telemetry/telemetry/page/csv_page_measurement_results.py - Issue 19857003: [Telemetry] Add a profiler based loading measurement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/csv_page_measurement_results.py

Issue 19857003: [Telemetry] Add a profiler based loading measurement. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add tests Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/csv_page_measurement_results.py

diff --git a/tools/telemetry/telemetry/page/csv_page_measurement_results.py b/tools/telemetry/telemetry/page/csv_page_measurement_results.py

index bd2e8d291193ee2e98f4006c6e610f681615c82b..2440dd86e736038470694a948fb22cde64b549d5 100644

--- a/tools/telemetry/telemetry/page/csv_page_measurement_results.py

+++ b/tools/telemetry/telemetry/page/csv_page_measurement_results.py

@@ -7,9 +7,10 @@ from telemetry.page import page_measurement_results

class CsvPageMeasurementResults(

page_measurement_results.PageMeasurementResults):

- def __init__(self, output_stream, output_after_every_page):

+ def __init__(self, output_stream=None, output_after_every_page=None):

super(CsvPageMeasurementResults, self).__init__()

- self._results_writer = csv.writer(output_stream)

+ if output_stream:

+ self._results_writer = csv.writer(output_stream)

self._did_output_header = False

self._header_names_written_to_writer = None

self._output_after_every_page = output_after_every_page