Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/perf/measurements/loading_measurement_analyzer.py

Issue 19857003: [Telemetry] Add a profiler based loading measurement. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add tests Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/measurements/loading_profile.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/loading_measurement_analyzer.py
diff --git a/tools/perf/measurements/loading_measurement_analyzer.py b/tools/perf/measurements/loading_measurement_analyzer.py
index eae217381705e8d012dabc3d79b1f31cfc3dde75..a5abe11ac685340ccca200c0a57dfb381d34a46b 100755
--- a/tools/perf/measurements/loading_measurement_analyzer.py
+++ b/tools/perf/measurements/loading_measurement_analyzer.py
@@ -9,7 +9,7 @@ Example usage:
$ tools/perf/run_measurement --browser=release \
--output-format=csv --output=/path/to/loading_measurement_output.csv \
loading_measurement tools/perf/page_sets/top_1m.json
-$ tools/perf/perf_tools/loading_measurement_analyzer.py \
+$ tools/perf/measurements/loading_measurement_analyzer.py \
--num-slowest-urls=100 --rank-csv-file=/path/to/top-1m.csv \
/path/to/loading_measurement_output.csv
"""
@@ -45,7 +45,7 @@ class LoadingMeasurementAnalyzer(object):
for key, value in row.iteritems():
if key in ('url', 'dom_content_loaded_time (ms)', 'load_time (ms)'):
continue
- if not value:
+ if not value or value == '-':
continue
if '_avg' in key:
self.avgs[key].append((float(value), row['url']))
@@ -89,7 +89,8 @@ class LoadingMeasurementAnalyzer(object):
if not self.num_slowest_urls:
return
- for key, values in self.totals.iteritems():
+ for key, values in sorted(self.totals.iteritems(), reverse=True,
+ key=lambda i: sum_totals[i[0]]):
print
print 'Top %d slowest %s:' % (self.num_slowest_urls,
key.replace(' (ms)', ''))
« no previous file with comments | « no previous file | tools/perf/measurements/loading_profile.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698