Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1984223002: Separates PreviousSessionInfo testing interface (Closed)

Created:
4 years, 7 months ago by gambard
Modified:
4 years, 7 months ago
Reviewers:
sdefresne, Olivier
CC:
asvitkine+watch_chromium.org, chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Separates PreviousSessionInfo testing interface This CL moves PreviousSessionInfo testing interface in a different header file. It also exposes isFirstSessionAfterUpgrade property as read-write for testing. BUG=none Committed: https://crrev.com/2653ed2b291cd04c496c1a8eb6a26ccc0bcd4a4b Cr-Commit-Position: refs/heads/master@{#396172}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/metrics/previous_session_info.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/chrome/browser/metrics/previous_session_info.mm View 1 chunk +1 line, -0 lines 0 comments Download
A ios/chrome/browser/metrics/previous_session_info_private.h View 1 chunk +20 lines, -0 lines 2 comments Download
M ios/chrome/browser/metrics/previous_session_info_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
gambard
4 years, 7 months ago (2016-05-26 12:03:03 UTC) #2
Olivier
https://codereview.chromium.org/1984223002/diff/1/ios/chrome/browser/metrics/previous_session_info_private.h File ios/chrome/browser/metrics/previous_session_info_private.h (right): https://codereview.chromium.org/1984223002/diff/1/ios/chrome/browser/metrics/previous_session_info_private.h#newcode14 ios/chrome/browser/metrics/previous_session_info_private.h:14: @property(nonatomic, assign) BOOL isFirstSessionAfterUpgrade; is this needed ?
4 years, 7 months ago (2016-05-26 12:18:31 UTC) #3
gambard
https://codereview.chromium.org/1984223002/diff/1/ios/chrome/browser/metrics/previous_session_info_private.h File ios/chrome/browser/metrics/previous_session_info_private.h (right): https://codereview.chromium.org/1984223002/diff/1/ios/chrome/browser/metrics/previous_session_info_private.h#newcode14 ios/chrome/browser/metrics/previous_session_info_private.h:14: @property(nonatomic, assign) BOOL isFirstSessionAfterUpgrade; On 2016/05/26 12:18:30, Olivier Robin ...
4 years, 7 months ago (2016-05-26 12:22:14 UTC) #4
Olivier
lgtm
4 years, 7 months ago (2016-05-26 12:28:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984223002/1
4 years, 7 months ago (2016-05-26 12:50:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/190336)
4 years, 7 months ago (2016-05-26 12:56:15 UTC) #9
gambard
+sdefresne for build files
4 years, 7 months ago (2016-05-26 13:01:40 UTC) #11
sdefresne
lgtm
4 years, 7 months ago (2016-05-26 14:01:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1984223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1984223002/1
4 years, 7 months ago (2016-05-26 14:14:37 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 14:21:38 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 14:23:21 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2653ed2b291cd04c496c1a8eb6a26ccc0bcd4a4b
Cr-Commit-Position: refs/heads/master@{#396172}

Powered by Google App Engine
This is Rietveld 408576698