Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 19839002: Improve test coverage of reflective invocation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/lib/lib.status » ('j') | tests/lib/mirrors/invoke_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
===================================================================
--- runtime/lib/mirrors_impl.dart (revision 25290)
+++ runtime/lib/mirrors_impl.dart (working copy)
@@ -226,10 +226,11 @@
var unwrappedValue;
if(_isSimpleValue(value)) {
unwrappedValue = value;
- } else if(wrappedArg is InstanceMirror) {
+ } else if(value is InstanceMirror) {
unwrappedValue = value._reflectee;
} else {
- throw "setter argument ($value) must be a simple value or InstanceMirror";
+ throw "setter argument ($value) must be"
+ "a simple value or InstanceMirror";
}
var result = this._invokeSetter(_reflectee,
« no previous file with comments | « no previous file | tests/lib/lib.status » ('j') | tests/lib/mirrors/invoke_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698