build/landmines.py - Issue 19836002: Blink roll 154563:154580

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/landmines.py

Issue 19836002: Blink roll 154563:154580 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comment Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/landmines.py

diff --git a/build/landmines.py b/build/landmines.py

index 753ad3bddf3e3a4ed9eb4ea3d2e660a24423996d..d2dcc16efee41747da2371b5a3e9325e8f867fac 100755

--- a/build/landmines.py

+++ b/build/landmines.py

@@ -157,6 +157,7 @@ def get_landmines(target):

gyp_defines().get('target_arch') == 'x64' and

gyp_defines().get('dcheck_always_on') == '1'):

add("Switched win x64 trybots from VS2010 to VS2012.")

+ add('Need to clobber everything due to and IDL change in r154579 (blink)')

gavinp 2013/07/19 20:32:30 Nit: "an IDL change"

return landmines

« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »