Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: build/landmines.py

Issue 19836002: Blink roll 154563:154580 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: need to add a landmine Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """ 6 """
7 This file holds a list of reasons why a particular build needs to be clobbered 7 This file holds a list of reasons why a particular build needs to be clobbered
8 (or a list of 'landmines'). 8 (or a list of 'landmines').
9 9
10 This script runs every build as a hook. If it detects that the build should 10 This script runs every build as a hook. If it detects that the build should
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 add('Compile on cc_unittests fails due to symbols removed in r185063.') 150 add('Compile on cc_unittests fails due to symbols removed in r185063.')
151 if platform() == 'linux' and builder() == 'ninja': 151 if platform() == 'linux' and builder() == 'ninja':
152 add('Builders switching from make to ninja will clobber on this.') 152 add('Builders switching from make to ninja will clobber on this.')
153 if platform() == 'mac': 153 if platform() == 'mac':
154 add('Switching from bundle to unbundled dylib (issue 14743002).') 154 add('Switching from bundle to unbundled dylib (issue 14743002).')
155 if (platform() == 'win' and builder() == 'ninja' and 155 if (platform() == 'win' and builder() == 'ninja' and
156 gyp_msvs_version() == '2012' and 156 gyp_msvs_version() == '2012' and
157 gyp_defines().get('target_arch') == 'x64' and 157 gyp_defines().get('target_arch') == 'x64' and
158 gyp_defines().get('dcheck_always_on') == '1'): 158 gyp_defines().get('dcheck_always_on') == '1'):
159 add("Switched win x64 trybots from VS2010 to VS2012.") 159 add("Switched win x64 trybots from VS2010 to VS2012.")
160 160
gavinp 2013/07/19 20:29:33 Put your add up above this blank line.
161 add('Need to clobber everything due to and IDL change in r154579 (blink)')
162
gavinp 2013/07/19 20:29:33 Remove this blank line.
161 return landmines 163 return landmines
162 164
163 165
164 def get_target_build_dir(build_tool, target, is_iphone=False): 166 def get_target_build_dir(build_tool, target, is_iphone=False):
165 """ 167 """
166 Returns output directory absolute path dependent on build and targets. 168 Returns output directory absolute path dependent on build and targets.
167 Examples: 169 Examples:
168 r'c:\b\build\slave\win\build\src\out\Release' 170 r'c:\b\build\slave\win\build\src\out\Release'
169 '/mnt/data/b/build/slave/linux/build/src/out/Debug' 171 '/mnt/data/b/build/slave/linux/build/src/out/Debug'
170 '/b/build/slave/ios_rel_device/build/src/xcodebuild/Release-iphoneos' 172 '/b/build/slave/ios_rel_device/build/src/xcodebuild/Release-iphoneos'
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 gyp_helper.apply_chromium_gyp_env() 236 gyp_helper.apply_chromium_gyp_env()
235 237
236 for target in ('Debug', 'Release', 'Debug_x64', 'Release_x64'): 238 for target in ('Debug', 'Release', 'Debug_x64', 'Release_x64'):
237 set_up_landmines(target) 239 set_up_landmines(target)
238 240
239 return 0 241 return 0
240 242
241 243
242 if __name__ == '__main__': 244 if __name__ == '__main__':
243 sys.exit(main()) 245 sys.exit(main())
OLDNEW
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698