Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Unified Diff: chrome/browser/media/encrypted_media_supported_types_browsertest.cc

Issue 1983563002: media: Add helper function to register pepper CDMs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more cleanup Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/encrypted_media_supported_types_browsertest.cc
diff --git a/chrome/browser/media/encrypted_media_supported_types_browsertest.cc b/chrome/browser/media/encrypted_media_supported_types_browsertest.cc
index 6c0b5b8c492f45099c0c35a812ba8b29eee36371..92d554fc79c5b140e9b2fd6a039f4c761dbbcc33 100644
--- a/chrome/browser/media/encrypted_media_supported_types_browsertest.cc
+++ b/chrome/browser/media/encrypted_media_supported_types_browsertest.cc
@@ -15,6 +15,7 @@
#include "base/threading/platform_thread.h"
#include "base/time/time.h"
#include "build/build_config.h"
+#include "chrome/browser/media/pepper_cdm_test_helper.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/chrome_paths.h"
@@ -95,29 +96,11 @@ const char kUnexpectedResult[] = "unexpected result";
#define EXPECT_WV_NO_MATCH EXPECT_UNKNOWN_KEYSYSTEM
#endif // defined(WIDEVINE_CDM_AVAILABLE) &&
// !defined(WIDEVINE_CDM_IS_COMPONENT)
-
-#if defined(ENABLE_PEPPER_CDMS)
-// Base path for Clear Key CDM (relative to the chrome executable).
-const char kClearKeyCdmBaseDirectory[] = "ClearKeyCdm";
-
-// Platform-specific filename relative to kClearKeyCdmBaseDirectory.
-const char kClearKeyCdmAdapterFileName[] =
-#if defined(OS_MACOSX)
- "clearkeycdmadapter.plugin";
-#elif defined(OS_WIN)
- "clearkeycdmadapter.dll";
-#elif defined(OS_POSIX)
- "libclearkeycdmadapter.so";
-#endif
-
-const char kClearKeyCdmPluginMimeType[] = "application/x-ppapi-clearkey-cdm";
-#endif // defined(ENABLE_PEPPER_CDMS)
-
}; // namespace
class EncryptedMediaSupportedTypesTest : public InProcessBrowserTest {
protected:
- EncryptedMediaSupportedTypesTest() : is_pepper_cdm_registered_(false) {
+ EncryptedMediaSupportedTypesTest() {
audio_webm_codecs_.push_back("opus");
audio_webm_codecs_.push_back("vorbis");
@@ -164,35 +147,6 @@ class EncryptedMediaSupportedTypesTest : public InProcessBrowserTest {
}
const CodecVector& invalid_codecs() const { return invalid_codecs_; }
- // Update the command line to load |adapter_name| for
- // |pepper_type_for_key_system|.
- void RegisterPepperCdm(base::CommandLine* command_line,
- const std::string& adapter_base_dir,
- const std::string& adapter_name,
- const std::string& pepper_type_for_key_system,
- bool expect_adapter_exists = true) {
- DCHECK(!is_pepper_cdm_registered_)
- << "RegisterPepperCdm() can only be called once.";
- is_pepper_cdm_registered_ = true;
-
- // Append the switch to register the appropriate adapter.
- base::FilePath plugin_dir;
- EXPECT_TRUE(PathService::Get(base::DIR_MODULE, &plugin_dir));
- plugin_dir = plugin_dir.AppendASCII(adapter_base_dir);
-
- base::FilePath plugin_lib = plugin_dir.AppendASCII(adapter_name);
- EXPECT_EQ(expect_adapter_exists, base::PathExists(plugin_lib));
- base::FilePath::StringType pepper_plugin = plugin_lib.value();
- pepper_plugin.append(FILE_PATH_LITERAL("#CDM#0.1.0.0;"));
-#if defined(OS_WIN)
- pepper_plugin.append(base::ASCIIToUTF16(pepper_type_for_key_system));
-#else
- pepper_plugin.append(pepper_type_for_key_system);
-#endif
- command_line->AppendSwitchNative(switches::kRegisterPepperPlugins,
- pepper_plugin);
- }
-
void SetUpOnMainThread() override {
InProcessBrowserTest::SetUpOnMainThread();
@@ -286,8 +240,6 @@ class EncryptedMediaSupportedTypesTest : public InProcessBrowserTest {
CodecVector video_mp4_codecs_;
CodecVector video_mp4_hi10p_codecs_;
CodecVector invalid_codecs_;
-
- bool is_pepper_cdm_registered_;
};
// For ClearKey, nothing additional is required.

Powered by Google App Engine
This is Rietveld 408576698