Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19828006: Windows fix for exportSyncfsFolderToLocalFs API. (Closed)

Created:
7 years, 5 months ago by Gaurav
Modified:
7 years, 5 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Windows fix for exportSyncfsFolderToLocalFs API. DeleteFile may return false is the file to be deleted does not exist on windows. Don't abort export syncfs folder operation if delete file fails. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213322

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Gaurav
7 years, 5 months ago (2013-07-22 22:43:53 UTC) #1
miket_OOO
lgtm
7 years, 5 months ago (2013-07-22 23:09:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/19828006/1
7 years, 5 months ago (2013-07-22 23:12:24 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-22 23:28:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/19828006/20001
7 years, 5 months ago (2013-07-23 18:39:06 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 5 months ago (2013-07-23 18:48:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/19828006/20001
7 years, 5 months ago (2013-07-23 19:09:23 UTC) #7
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 02:33:52 UTC) #8
Message was sent while issue was closed. 
Change committed as 213322

Powered by Google App Engine
This is Rietveld 408576698