Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 19818005: Remove setTimeout for serviceNextCopyTaskEntry_(). (Closed)

Created:
7 years, 5 months ago by hidehiko
Modified:
7 years, 5 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org, hirono
Visibility:
Public.

Description

Remove setTimeout for serviceNextCopyTaskEntry_(). FileCopyManager.serviceNextCopyTaskEntry_() already works in asynchronous way, so it shouldn't be necessary to run it with setTimeout(). BUG=246976 TEST=Ran browser_tests --gtest_filter="*FileSystemExtensionApiTest*:*FileManagerBrowserTest*". Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/browser/resources/file_manager/js/file_copy_manager.js View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hidehiko
This is what we talking in cl 19536004. Thank you for your review in advance, ...
7 years, 5 months ago (2013-07-23 16:44:05 UTC) #1
mtomasz
On 2013/07/23 16:44:05, hidehiko wrote: > This is what we talking in cl 19536004. > ...
7 years, 5 months ago (2013-07-24 01:13:03 UTC) #2
hidehiko
On 2013/07/24 01:13:03, mtomasz wrote: > On 2013/07/23 16:44:05, hidehiko wrote: > > This is ...
7 years, 5 months ago (2013-07-24 02:32:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/19818005/1
7 years, 5 months ago (2013-07-24 02:34:40 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-24 10:28:46 UTC) #5
Message was sent while issue was closed.
Change committed as 213388

Powered by Google App Engine
This is Rietveld 408576698