Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: media/cdm/ppapi/ppapi_cdm_adapter.gni

Issue 1981723002: media: Set RUNPATH in cdm adapter in GN component build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cdm/ppapi/ppapi_cdm_adapter.gni
diff --git a/media/cdm/ppapi/ppapi_cdm_adapter.gni b/media/cdm/ppapi/ppapi_cdm_adapter.gni
index a8e80ec64616c52b849e74072ae75473fa332faa..c4c7f878e4cffe406b98997a35cb466013c606ef 100644
--- a/media/cdm/ppapi/ppapi_cdm_adapter.gni
+++ b/media/cdm/ppapi/ppapi_cdm_adapter.gni
@@ -59,8 +59,8 @@ template("ppapi_cdm_adapter") {
libs += [ "rt" ]
}
- if (is_linux && !is_component_build) {
- # CDM adapter depends on a CDM even in non-component builds.
+ if (is_linux) {
+ # CDM adapter depends on a CDM in component and non-component builds.
configs += [ "//build/config/gcc:rpath_for_built_shared_libraries" ]
ddorwin 2016/05/16 18:11:12 I know we need to set rpath for the adapter, but t
xhwang 2016/05/16 18:23:07 This was discussed when we added this back. See ht
ddorwin 2016/05/16 18:28:46 thestig@: Should we update the documentation in th
Lei Zhang 2016/05/17 20:31:15 Meh. The config("executable_ldconfig") section in
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698