Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: content/common/gpu/gpu_channel_manager.h

Issue 198073003: Remove some content_child dependency from content_common (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ffd442cb fix for bots barfing on clang style checks Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/gpu/DEPS ('k') | content/common/gpu/gpu_channel_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/gpu_channel_manager.h
diff --git a/content/common/gpu/gpu_channel_manager.h b/content/common/gpu/gpu_channel_manager.h
index eb4d224d9b70f6c98e4315cbdba62b6d42c5a6a0..638028eb0bf219a7c94d49659e1d784dbc86f2f1 100644
--- a/content/common/gpu/gpu_channel_manager.h
+++ b/content/common/gpu/gpu_channel_manager.h
@@ -44,25 +44,18 @@ struct ChannelHandle;
struct GPUCreateCommandBufferConfig;
namespace content {
-class ChildThread;
class GpuChannel;
class GpuWatchdog;
+class MessageRouter;
class SyncPointManager;
// A GpuChannelManager is a thread responsible for issuing rendering commands
// managing the lifetimes of GPU channels and forwarding IPC requests from the
// browser process to them based on the corresponding renderer ID.
-//
-// A GpuChannelManager can also be hosted in the browser process in single
-// process or in-process GPU modes. In this case there is no corresponding
-// GpuChildThread and this is the reason the GpuChildThread is referenced via
-// a pointer to IPC::Sender, which can be implemented by other hosts to send
-// IPC messages to the browser process IO thread on the GpuChannelManager's
-// behalf.
class GpuChannelManager : public IPC::Listener,
public IPC::Sender {
public:
- GpuChannelManager(ChildThread* gpu_child_thread,
+ GpuChannelManager(MessageRouter* router,
GpuWatchdog* watchdog,
base::MessageLoopProxy* io_message_loop,
base::WaitableEvent* shutdown_event);
@@ -138,7 +131,7 @@ class GpuChannelManager : public IPC::Listener,
base::WaitableEvent* shutdown_event_;
// Used to send and receive IPC messages from the browser process.
- ChildThread* gpu_child_thread_;
+ MessageRouter* const router_;
// These objects manage channels to individual renderer processes there is
// one channel for each renderer process that has connected to this GPU
« no previous file with comments | « content/common/gpu/DEPS ('k') | content/common/gpu/gpu_channel_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698