remoting/base/resources_win.cc - Issue 19803010: Localized Chromoting Host on Mac and Linux.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/base/resources_win.cc

Issue 19803010: Localized Chromoting Host on Mac and Linux. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "remoting/base/resources.h"

	6

	7 #include "base/logging.h"

	8

	9 namespace remoting {

	10

	11 void LoadResources(const std::string& pref_locale) {

	12 // .pak files are not used on Windows.

	13 NOTREACHED();
	Sergey Ulanov 2013/07/23 22:45:40 Is that right? ResourceTest still calls this funct Is that right? ResourceTest still calls this function. I think this function should be either empty or shouldn't exist on Windows if it's not expected to be used there. alexeypa (please no reviews) 2013/07/23 23:35:26 Yes, you are right I'll update this part. Show quoted text On 2013/07/23 22:45:40, Sergey Ulanov wrote: > Is that right? ResourceTest still calls this function. I think this function > should be either empty or shouldn't exist on Windows if it's not expected to be > used there. Yes, you are right I'll update this part.
	14 }

	15

	16 void UnloadResources() {

	17 // .pak files are not used on Windows.

	18 NOTREACHED();

	19 }

	20

	21 } // namespace remoting

OLD	NEW